2018-04-25 05:53:49

by Li Bin

Subject: [PATCH] sched: fix typo in error message

Signed-off-by: Li Bin <[email protected]>
---
kernel/sched/topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index 64cc564..cf15c1c 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -1618,7 +1618,7 @@ static struct sched_domain *build_sched_domain(struct sched_domain_topology_leve

if (!cpumask_subset(sched_domain_span(child),
sched_domain_span(sd))) {
- pr_err("BUG: arch topology borken\n");
+ pr_err("BUG: arch topology broken\n");
#ifdef CONFIG_SCHED_DEBUG
pr_err(" the %s domain not a subset of the %s domain\n",
child->name, sd->name);
--
1.7.12.4

2018-04-25 06:32:25

by Mike Galbraith

Subject: Re: [PATCH] sched: fix typo in error message

On Wed, 2018-04-25 at 13:41 +0800, Li Bin wrote:
> Signed-off-by: Li Bin <[email protected]>
> ---
> kernel/sched/topology.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> index 64cc564..cf15c1c 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -1618,7 +1618,7 @@ static struct sched_domain *build_sched_domain(struct sched_domain_topology_leve
>
> if (!cpumask_subset(sched_domain_span(child),
> sched_domain_span(sd))) {
> - pr_err("BUG: arch topology borken\n");
> + pr_err("BUG: arch topology broken\n");

That's not a typo, it's a kernel-speak synonym, as are "borked",
b0rked", "b0rken", "busted", "hosed", and lord knows how many other
colorful variants. Non-native English speakers beware.

-Mike

2018-04-25 07:07:58

by Peter Zijlstra

Subject: Re: [PATCH] sched: fix typo in error message

Again.. if only people would use google, they'd find at least 3 other
people having tried this patch :/

On Wed, Apr 25, 2018 at 01:41:40PM +0800, Li Bin wrote:
> - pr_err("BUG: arch topology borken\n");
> + pr_err("BUG: arch topology broken\n");

Not a typo:

https://www.urbandictionary.com/define.php?term=borken