2018-05-13 23:34:35

by Hernán Gonzalez

Subject: [PATCH] net: ethernet: ti: Use ERR_CAST instead of ERR_PTR(PTR_ERR())

Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...)).

drivers/net/ethernet/ti/cpts.c:567:9-16: WARNING: ERR_CAST can be used with cpts->refclk
Generated by: scripts/coccinelle/api/err_cast.cocci

Signed-off-by: Hernán Gonzalez <[email protected]>
---
drivers/net/ethernet/ti/cpts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c
index e7b76f6..7842f09 100644
--- a/drivers/net/ethernet/ti/cpts.c
+++ b/drivers/net/ethernet/ti/cpts.c
@@ -564,7 +564,7 @@ struct cpts *cpts_create(struct device *dev, void __iomem *regs,
cpts->refclk = devm_clk_get(dev, "cpts");
if (IS_ERR(cpts->refclk)) {
dev_err(dev, "Failed to get cpts refclk\n");
- return ERR_PTR(PTR_ERR(cpts->refclk));
+ return ERR_CAST(cpts->refclk);
}

clk_prepare(cpts->refclk);
--
2.7.4

2018-05-14 20:30:14

by David Miller

Subject: Re: [PATCH] net: ethernet: ti: Use ERR_CAST instead of ERR_PTR(PTR_ERR())

From: Hern?n Gonzalez <[email protected]>
Date: Sun, 13 May 2018 20:33:49 -0300

> Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...)).
>
> drivers/net/ethernet/ti/cpts.c:567:9-16: WARNING: ERR_CAST can be used with cpts->refclk
> Generated by: scripts/coccinelle/api/err_cast.cocci
>
> Signed-off-by: Hern?n Gonzalez <[email protected]>

Applied to net-next, thank you.