2018-06-07 19:53:42

by Corentin LABBE

[permalink] [raw]
Subject: [PATCH] bluetooth: remove unused bt-nokia-h4p.h header

Nothing in tree use this header which seems a remains of a staging
driver.
This patch remove it.

Signed-off-by: Corentin Labbe <[email protected]>
---
include/linux/platform_data/bt-nokia-h4p.h | 38 ------------------------------
1 file changed, 38 deletions(-)
delete mode 100644 include/linux/platform_data/bt-nokia-h4p.h

diff --git a/include/linux/platform_data/bt-nokia-h4p.h b/include/linux/platform_data/bt-nokia-h4p.h
deleted file mode 100644
index 30d169dfadf3..000000000000
--- a/include/linux/platform_data/bt-nokia-h4p.h
+++ /dev/null
@@ -1,38 +0,0 @@
-/*
- * This file is part of Nokia H4P bluetooth driver
- *
- * Copyright (C) 2010 Nokia Corporation.
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * version 2 as published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
- * 02110-1301 USA
- *
- */
-
-
-/**
- * struct hci_h4p_platform data - hci_h4p Platform data structure
- */
-struct hci_h4p_platform_data {
- int chip_type;
- int bt_sysclk;
- unsigned int bt_wakeup_gpio;
- unsigned int host_wakeup_gpio;
- unsigned int reset_gpio;
- int reset_gpio_shared;
- unsigned int uart_irq;
- phys_addr_t uart_base;
- const char *uart_iclk;
- const char *uart_fclk;
- void (*set_pm_limits)(struct device *dev, bool set);
-};
--
2.16.4



2018-06-10 00:30:28

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [PATCH] bluetooth: remove unused bt-nokia-h4p.h header

Hi,

On Thu, Jun 07, 2018 at 07:50:38PM +0000, Corentin Labbe wrote:
> Nothing in tree use this header which seems a remains of a staging
> driver.
> This patch remove it.
>
> Signed-off-by: Corentin Labbe <[email protected]>

Right, this is not used by drivers/bluetooth/hci_nokia.c, but a
leftover from the staging driver.

Reviewed-by: Sebastian Reichel <[email protected]>

-- Sebastian

> ---
> include/linux/platform_data/bt-nokia-h4p.h | 38 ------------------------------
> 1 file changed, 38 deletions(-)
> delete mode 100644 include/linux/platform_data/bt-nokia-h4p.h
>
> diff --git a/include/linux/platform_data/bt-nokia-h4p.h b/include/linux/platform_data/bt-nokia-h4p.h
> deleted file mode 100644
> index 30d169dfadf3..000000000000
> --- a/include/linux/platform_data/bt-nokia-h4p.h
> +++ /dev/null
> @@ -1,38 +0,0 @@
> -/*
> - * This file is part of Nokia H4P bluetooth driver
> - *
> - * Copyright (C) 2010 Nokia Corporation.
> - *
> - * This program is free software; you can redistribute it and/or
> - * modify it under the terms of the GNU General Public License
> - * version 2 as published by the Free Software Foundation.
> - *
> - * This program is distributed in the hope that it will be useful, but
> - * WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> - * General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
> - * 02110-1301 USA
> - *
> - */
> -
> -
> -/**
> - * struct hci_h4p_platform data - hci_h4p Platform data structure
> - */
> -struct hci_h4p_platform_data {
> - int chip_type;
> - int bt_sysclk;
> - unsigned int bt_wakeup_gpio;
> - unsigned int host_wakeup_gpio;
> - unsigned int reset_gpio;
> - int reset_gpio_shared;
> - unsigned int uart_irq;
> - phys_addr_t uart_base;
> - const char *uart_iclk;
> - const char *uart_fclk;
> - void (*set_pm_limits)(struct device *dev, bool set);
> -};
> --
> 2.16.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html


Attachments:
(No filename) (2.37 kB)
signature.asc (849.00 B)
Download all attachments

2018-07-06 10:53:40

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH] bluetooth: remove unused bt-nokia-h4p.h header

Hi Corentin,

> Nothing in tree use this header which seems a remains of a staging
> driver.
> This patch remove it.
>
> Signed-off-by: Corentin Labbe <[email protected]>
> ---
> include/linux/platform_data/bt-nokia-h4p.h | 38 ------------------------------
> 1 file changed, 38 deletions(-)
> delete mode 100644 include/linux/platform_data/bt-nokia-h4p.h

patch has been applied to bluetooth-next tree.

Regards

Marcel