2018-06-12 11:52:40

by Chengguang Xu

Subject: [PATCH v2] x86: remove redundant check for kmem_cache_create()

The flag 'SLAB_PANIC' implies panic when encouter failure,
So there is no need to check NULL pointer for cache creation.

Signed-off-by: Chengguang Xu <[email protected]>
---
v1->v2:
- Keep return type as int instead of changing to void.

arch/x86/mm/pgtable.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/arch/x86/mm/pgtable.c b/arch/x86/mm/pgtable.c
index 47b5951..406873d 100644
--- a/arch/x86/mm/pgtable.c
+++ b/arch/x86/mm/pgtable.c
@@ -329,9 +329,6 @@ static int __init pgd_cache_init(void)
*/
pgd_cache = kmem_cache_create("pgd_cache", PGD_SIZE, PGD_ALIGN,
SLAB_PANIC, NULL);
- if (!pgd_cache)
- return -ENOMEM;
-
return 0;
}
core_initcall(pgd_cache_init);
--
1.8.3.1

2018-08-02 12:34:15

by tip-bot for Vasyl Gomonovych

Subject: [tip:x86/mm] x86/mm: Remove redundant check for kmem_cache_create()

Commit-ID: 765d28f136291f9639e3c031a1070fb76d6625c7
Gitweb: https://git.kernel.org/tip/765d28f136291f9639e3c031a1070fb76d6625c7
Author: Chengguang Xu <[email protected]>
AuthorDate: Tue, 12 Jun 2018 19:48:52 +0800
Committer: Thomas Gleixner <[email protected]>
CommitDate: Thu, 2 Aug 2018 14:27:35 +0200

x86/mm: Remove redundant check for kmem_cache_create()

The flag 'SLAB_PANIC' implies panic on failure, So there is no need to
check the returned pointer for NULL.

Signed-off-by: Chengguang Xu <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Cc: [email protected]
Link: https://lkml.kernel.org/r/[email protected]

---
arch/x86/mm/pgtable.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/arch/x86/mm/pgtable.c b/arch/x86/mm/pgtable.c
index e3deefb891da..0f1683fcb196 100644
--- a/arch/x86/mm/pgtable.c
+++ b/arch/x86/mm/pgtable.c
@@ -329,9 +329,6 @@ static int __init pgd_cache_init(void)
*/
pgd_cache = kmem_cache_create("pgd_cache", PGD_SIZE, PGD_ALIGN,
SLAB_PANIC, NULL);
- if (!pgd_cache)
- return -ENOMEM;
-
return 0;
}
core_initcall(pgd_cache_init);