2018-06-21 10:39:58

by Abdul Haleem

[permalink] [raw]
Subject: [4.18.0-rc1][i40e][9b10df59] WARNING: CPU: 32 PID: 95246 at drivers/net/ethernet/intel/i40e/i40e_ethtool.c:1907 i40e_update_ethtool_fdir_entry.isra.12+0x2264/0x2270

Greeting's

WARN_ONCE is triggered when interface is toggled when running 'ethtool -S' command
on a powerpc machine running today's mainline kernel

related commit looks to be:

commit 9b10df596bd4d38f2a58cf87e0780510acc53d8d
Author: Jacob Keller <[email protected]>
Date: Thu May 17 01:08:36 2018 -0700

i40e: use WARN_ONCE to replace the commented BUG_ON size check

We don't really want to use BUG_ON here since that would completely
crash the kernel, thus the reason we commented it out. We *can't* use
BUILD_BUG_ON because at least now (a) the sizes aren't constant (we are
fixing this) and (b) not all compilers are smart enough to understand
that "p - data" is a constant.

Machine: Power 8 bare-metal
kernel: 4.18.0-rc1
ethtool: version 4.8
gcc: 4.8.5
config: attached

Adapter: Ethernet controller [0200]: Intel Corporation Ethernet
Controller X710/X557-AT 10GBASE-T [8086:1589] (rev 02)

dmesg:
------
i40e 0002:01:00.2 enP2p1s0f2: NIC Link is Down
i40e 0002:01:00.2 enP2p1s0f2: NIC Link is Up, 10 Gbps Full Duplex, Flow Control: None
i40e 0002:01:00.2 enP2p1s0f2: NIC Link is Down
i40e 0002:01:00.2 enP2p1s0f2: NIC Link is Up, 10 Gbps Full Duplex, Flow Control: None
i40e 0002:01:00.0 net0: NIC Link is Down
i40e 0002:01:00.2 enP2p1s0f2: NIC Link is Down
i40e 0002:01:00.3 enP2p1s0f3: NIC Link is Down
i40e 0002:01:00.0 net0: NIC Link is Up, 1000 Mbps Full Duplex, Flow Control: None
i40e 0002:01:00.3 enP2p1s0f3: NIC Link is Up, 10 Gbps Full Duplex, Flow Control: None
i40e 0002:01:00.2 enP2p1s0f2: NIC Link is Up, 10 Gbps Full Duplex, Flow Control: None
i40e 0002:01:00.0 net0: NIC Link is Down
i40e 0002:01:00.2 enP2p1s0f2: NIC Link is Down
i40e 0002:01:00.3 enP2p1s0f3: NIC Link is Down
i40e 0002:01:00.0 net0: NIC Link is Up, 1000 Mbps Full Duplex, Flow Control: None
i40e 0002:01:00.2 enP2p1s0f2: NIC Link is Up, 10 Gbps Full Duplex, Flow Control: None
i40e 0002:01:00.3 enP2p1s0f3: NIC Link is Up, 10 Gbps Full Duplex, Flow Control: None
------------[ cut here ]------------
stat strings count mismatch!
WARNING: CPU: 81 PID: 24268 at drivers/net/ethernet/intel/i40e/i40e_ethtool.c:1907 i40e_update_ethtool_fdir_entry.isra.12+0x2264/0x2270 [i40e]
Modules linked in: ipt_MASQUERADE tun bridge stp llc xt_tcpudp
ipt_REJECT nf_reject_ipv4 xt_conntrack nfnetlink iptable_nat
nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 nf_nat nf_conntrack
iptable_mangle iptable_filter btrfs xor zstd_decompress zstd_compress
xxhash lzo_compress vmx_crypto raid6_pq powernv_rng rng_core kvm_hv kvm
nfsd ip_tables x_tables xfs libcrc32c qla2xxx mpt3sas nvme_fc
nvme_fabrics raid_class i40e nvme_core scsi_transport_sas
CPU: 81 PID: 24268 Comm: ethtool Not tainted 4.18.0-rc1-autotest-autotest #1
NIP: d000000010260634 LR: d000000010260630 CTR: c0000000009dc580
REGS: c000007fe2c2f730 TRAP: 0700 Not tainted (4.18.0-rc1-autotest-autotest)
MSR: 9000000000029033 <SF,HV,EE,ME,IR,DR,RI,LE> CR: 48028422 XER: 20000000
CFAR: c0000000000f1d98 IRQMASK: 0
GPR00: d000000010260630 c000007fe2c2f9b0 d00000001029cc00 000000000000001c
GPR04: 0000000000000001 000000000000000c 0000000000000001 c00000000115be00
GPR08: 0000000000000001 0000000000000007 0000000000000006 9000000000001003
GPR12: 0000000000008800 c000007fff7fe580 0000000000000000 0000000000000000
GPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
GPR20: d00000001028e500 d00000001028e518 d00000001028e530 d00000001028e548
GPR24: d00000001028e598 d00000001028e5b0 c000003fec19d000 d00000001028e5d0
GPR28: 0000000000000008 00000000000054c0 ffffffffffffab40 d00000001b4a54c0
NIP [d000000010260634] i40e_update_ethtool_fdir_entry.isra.12+0x2264/0x2270 [i40e]
LR [d000000010260630] i40e_update_ethtool_fdir_entry.isra.12+0x2260/0x2270 [i40e]
Call Trace:
[c000007fe2c2f9b0] [d000000010260630] i40e_update_ethtool_fdir_entry.isra.12+0x2260/0x2270 [i40e] (unreliable)
[c000007fe2c2fa70] [c0000000008a3990] dev_ethtool+0x1880/0x27b0
[c000007fe2c2fba0] [c0000000008c86a0] dev_ioctl+0x560/0x7e0
[c000007fe2c2fbf0] [c000000000869510] sock_do_ioctl+0xc0/0x1a0
[c000007fe2c2fc60] [c000000000869ed0] sock_ioctl+0x1a0/0x460
[c000007fe2c2fd20] [c000000000329dc8] do_vfs_ioctl+0xc8/0x8b0
[c000007fe2c2fdc0] [c00000000032a60c] ksys_ioctl+0x5c/0xe0
[c000007fe2c2fe10] [c00000000032a6b0] sys_ioctl+0x20/0x80
[c000007fe2c2fe30] [c00000000000b9e4] system_call+0x5c/0x70
Instruction dump:
41fefc1c 3d220000 e9298e80 89490000 2f8a0000 40fefc08 3c620000 e8638e88
39400001 99490000 48022d45 e8410018 <0fe00000> 4bfffbe8 60420000 3c4c0004
---[ end trace 1a1b8331349cf7fd ]---

--
Regard's

Abdul Haleem
IBM Linux Technology Centre



Attachments:
Hab-NV-config_with_NVMe (89.66 kB)