2018-06-25 01:53:33

by Prakhya, Sai Praneeth

Subject: [PATCH] efi: Remove the declaration of efi_late_init() as the function is unused

From: Sai Praneeth <[email protected]>

Commit 7b0a911478c74 (efi/x86: Move the EFI BGRT init code to early
init code), removed the implementation and all the references to
efi_late_init() but the function is still declared at
include/linux/efi.h. Hence, remove the unnecessary declaration.

Signed-off-by: Sai Praneeth Prakhya <[email protected]>
Cc: Lee Chun-Yi <[email protected]>
Cc: Borislav Petkov <[email protected]>
Cc: Dave Young <[email protected]>
Cc: Bhupesh Sharma <[email protected]>
Cc: Ricardo Neri <[email protected]>
Cc: Ravi Shankar <[email protected]>
Cc: Matt Fleming <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
---
include/linux/efi.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/include/linux/efi.h b/include/linux/efi.h
index 56add823f190..ae47be636b98 100644
--- a/include/linux/efi.h
+++ b/include/linux/efi.h
@@ -988,14 +988,12 @@ extern void efi_memmap_walk (efi_freemem_callback_t callback, void *arg);
extern void efi_gettimeofday (struct timespec64 *ts);
extern void efi_enter_virtual_mode (void); /* switch EFI to virtual mode, if possible */
#ifdef CONFIG_X86
-extern void efi_late_init(void);
extern void efi_free_boot_services(void);
extern efi_status_t efi_query_variable_store(u32 attributes,
unsigned long size,
bool nonblocking);
extern void efi_find_mirror(void);
#else
-static inline void efi_late_init(void) {}
static inline void efi_free_boot_services(void) {}

static inline efi_status_t efi_query_variable_store(u32 attributes,
--
2.7.4

2018-06-25 06:03:06

by Ard Biesheuvel

Subject: Re: [PATCH] efi: Remove the declaration of efi_late_init() as the function is unused

On 25 June 2018 at 03:47, Sai Praneeth Prakhya
<[email protected]> wrote:
> From: Sai Praneeth <[email protected]>
>
> Commit 7b0a911478c74 (efi/x86: Move the EFI BGRT init code to early
> init code), removed the implementation and all the references to
> efi_late_init() but the function is still declared at
> include/linux/efi.h. Hence, remove the unnecessary declaration.
>
> Signed-off-by: Sai Praneeth Prakhya <[email protected]>
> Cc: Lee Chun-Yi <[email protected]>
> Cc: Borislav Petkov <[email protected]>
> Cc: Dave Young <[email protected]>
> Cc: Bhupesh Sharma <[email protected]>
> Cc: Ricardo Neri <[email protected]>
> Cc: Ravi Shankar <[email protected]>
> Cc: Matt Fleming <[email protected]>
> Cc: Ard Biesheuvel <[email protected]>

Thanks Sai

Queued in efi/next

> ---
> include/linux/efi.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/efi.h b/include/linux/efi.h
> index 56add823f190..ae47be636b98 100644
> --- a/include/linux/efi.h
> +++ b/include/linux/efi.h
> @@ -988,14 +988,12 @@ extern void efi_memmap_walk (efi_freemem_callback_t callback, void *arg);
> extern void efi_gettimeofday (struct timespec64 *ts);
> extern void efi_enter_virtual_mode (void); /* switch EFI to virtual mode, if possible */
> #ifdef CONFIG_X86
> -extern void efi_late_init(void);
> extern void efi_free_boot_services(void);
> extern efi_status_t efi_query_variable_store(u32 attributes,
> unsigned long size,
> bool nonblocking);
> extern void efi_find_mirror(void);
> #else
> -static inline void efi_late_init(void) {}
> static inline void efi_free_boot_services(void) {}
>
> static inline efi_status_t efi_query_variable_store(u32 attributes,
> --
> 2.7.4
>