2018-06-25 10:55:24

by Mika Penttilä

[permalink] [raw]
Subject: [PATCH] Regression fix for Chipidea USB

From: Mika Penttilä <[email protected]>

I started to see usb failures on i.MX6, like "nonzero urb status received" after:

" commit 4e88d4c083016454f179686529ae65d70b933b58
Author: Martin Blumenstingl <[email protected]>
Date: Sat Mar 3 22:43:03 2018 +0100

usb: add a flag to skip PHY initialization to struct usb_hcd"

The errors were related to some scpecific scenarios, like usb device reset, disappear etc.

The fix below worked for me.

--Mika


Signed-off-by: Mika Penttilä <[email protected]>

---
drivers/usb/chipidea/host.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/usb/chipidea/host.c b/drivers/usb/chipidea/host.c
index af45aa32..c45d081 100644
--- a/drivers/usb/chipidea/host.c
+++ b/drivers/usb/chipidea/host.c
@@ -124,6 +124,9 @@ static int host_start(struct ci_hdrc *ci)

hcd->power_budget = ci->platdata->power_budget;
hcd->tpl_support = ci->platdata->tpl_support;
+
+ hcd->usb_phy = ci->usb_phy;
+
if (ci->phy || ci->usb_phy)
hcd->skip_phy_initialization = 1;

--
1.9.1



2018-06-25 13:23:00

by Johan Hovold

[permalink] [raw]
Subject: Re: [PATCH] Regression fix for Chipidea USB

On Mon, Jun 25, 2018 at 01:54:05PM +0300, [email protected] wrote:
> From: Mika Penttil? <[email protected]>
>
> I started to see usb failures on i.MX6, like "nonzero urb status received" after:
>
> " commit 4e88d4c083016454f179686529ae65d70b933b58
> Author: Martin Blumenstingl <[email protected]>
> Date: Sat Mar 3 22:43:03 2018 +0100
>
> usb: add a flag to skip PHY initialization to struct usb_hcd"
>
> The errors were related to some scpecific scenarios, like usb device
> reset, disappear etc.

This was reported earlier and a fix has been posted here:

https://marc.info/?l=linux-usb&m=152825077301574

Should be addressed in 4.18-rc shortly.

Thanks,
Johan