2018-07-09 19:55:05

by Corentin LABBE

[permalink] [raw]
Subject: [PATCH] ARM: dts: sun8i: sun8i-a83t-bananapi-m3: enhance vcc-pd to 3.3v

Since commit d7c5f6863550 ("ARM: dts: sun8i: a83t: bananapi-m3: Add AXP813 regulator nodes")
my BPIM3 no longer works at gigabit speed.

With the default setting, dldo3 is regulated at 2.9v which seems
sufficient for the PHy but d7c5f6863550 drop it to 2.5 which is insufficient.
Note that this behaviour is random for all BPIM3 (some works with 2.5, some not)

Finnaly, someone from bananapi confirmed that this regulator must be set to 3.3

Fixes: d7c5f6863550 ("ARM: dts: sun8i: a83t: bananapi-m3: Add AXP813 regulator nodes")
Signed-off-by: Corentin Labbe <[email protected]>
---
arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts b/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts
index c7ce4158d6c8..f250b20af493 100644
--- a/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts
+++ b/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts
@@ -309,8 +309,8 @@

&reg_dldo3 {
regulator-always-on;
- regulator-min-microvolt = <2500000>;
- regulator-max-microvolt = <2500000>;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
regulator-name = "vcc-pd";
};

--
2.16.4



2018-07-11 08:25:59

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: sun8i: sun8i-a83t-bananapi-m3: enhance vcc-pd to 3.3v

On Mon, Jul 09, 2018 at 07:51:54PM +0000, Corentin Labbe wrote:
> Since commit d7c5f6863550 ("ARM: dts: sun8i: a83t: bananapi-m3: Add AXP813 regulator nodes")
> my BPIM3 no longer works at gigabit speed.
>
> With the default setting, dldo3 is regulated at 2.9v which seems
> sufficient for the PHy but d7c5f6863550 drop it to 2.5 which is insufficient.
> Note that this behaviour is random for all BPIM3 (some works with 2.5, some not)
>
> Finnaly, someone from bananapi confirmed that this regulator must be set to 3.3
>
> Fixes: d7c5f6863550 ("ARM: dts: sun8i: a83t: bananapi-m3: Add AXP813 regulator nodes")
> Signed-off-by: Corentin Labbe <[email protected]>

Applied, thanks!
Maxime

--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

Attachments:
(No filename) (825.00 B)
 signature.asc (849.00 B)
 Download all attachments