2018-07-22 15:47:48

by Akinobu Mita

[permalink] [raw]
Subject: [PATCH -next] regmap: sccb: fix typo and sort headers alphabetically

Fix typos 's/wit/with/' in the comments and sort headers alphabetically
in order to avoid duplicate includes in future.

Fixes: bcf7eac3d97f ("regmap: add SCCB support")
Reported-by: Wolfram Sang <[email protected]>
Cc: Wolfram Sang <[email protected]>
Cc: Mark Brown <[email protected]>
Signed-off-by: Akinobu Mita <[email protected]>
---
drivers/base/regmap/regmap-sccb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/base/regmap/regmap-sccb.c b/drivers/base/regmap/regmap-sccb.c
index b6eb876..597042e2 100644
--- a/drivers/base/regmap/regmap-sccb.c
+++ b/drivers/base/regmap/regmap-sccb.c
@@ -1,9 +1,9 @@
// SPDX-License-Identifier: GPL-2.0
// Register map access API - SCCB support

-#include <linux/regmap.h>
#include <linux/i2c.h>
#include <linux/module.h>
+#include <linux/regmap.h>

#include "internal.h"

@@ -29,7 +29,7 @@ static bool sccb_is_available(struct i2c_adapter *adap)

/**
* regmap_sccb_read - Read data from SCCB slave device
- * @context: Device that will be interacted wit
+ * @context: Device that will be interacted with
* @reg: Register to be read from
* @val: Pointer to store read value
*
@@ -65,7 +65,7 @@ static int regmap_sccb_read(void *context, unsigned int reg, unsigned int *val)

/**
* regmap_sccb_write - Write data to SCCB slave device
- * @context: Device that will be interacted wit
+ * @context: Device that will be interacted with
* @reg: Register to write to
* @val: Value to be written
*
--
2.7.4



2018-07-22 17:39:08

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH -next] regmap: sccb: fix typo and sort headers alphabetically

On Mon, Jul 23, 2018 at 12:45:46AM +0900, Akinobu Mita wrote:
> Fix typos 's/wit/with/' in the comments and sort headers alphabetically
> in order to avoid duplicate includes in future.
>
> Fixes: bcf7eac3d97f ("regmap: add SCCB support")
> Reported-by: Wolfram Sang <[email protected]>

Could this be replaced with (as I did this in my work time):

Reported-by: Wolfram Sang <[email protected]>

?

> Cc: Wolfram Sang <[email protected]>
> Cc: Mark Brown <[email protected]>
> Signed-off-by: Akinobu Mita <[email protected]>

Looks good, thanks!

Reviewed-by: Wolfram Sang <[email protected]>


Attachments:
(No filename) (653.00 B)
signature.asc (849.00 B)
Download all attachments