2018-07-23 21:00:59

by Bjorn Helgaas

[permalink] [raw]
Subject: [PATCH] vxge: Remove unnecessary include of <linux/pci_hotplug.h>

From: Bjorn Helgaas <[email protected]>

The vxge driver doesn't need anything provided by pci_hotplug.h, so remove
the unnecessary include of it.

Signed-off-by: Bjorn Helgaas <[email protected]>
---
drivers/net/ethernet/neterion/vxge/vxge-config.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/neterion/vxge/vxge-config.c b/drivers/net/ethernet/neterion/vxge/vxge-config.c
index 358ed6118881..a2c0a93ca8b6 100644
--- a/drivers/net/ethernet/neterion/vxge/vxge-config.c
+++ b/drivers/net/ethernet/neterion/vxge/vxge-config.c
@@ -14,7 +14,6 @@
#include <linux/vmalloc.h>
#include <linux/etherdevice.h>
#include <linux/pci.h>
-#include <linux/pci_hotplug.h>
#include <linux/slab.h>

#include "vxge-traffic.h"



2018-07-24 15:47:37

by Jon Mason

[permalink] [raw]
Subject: Re: [PATCH] vxge: Remove unnecessary include of <linux/pci_hotplug.h>

On Mon, Jul 23, 2018 at 03:59:46PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <[email protected]>
>
> The vxge driver doesn't need anything provided by pci_hotplug.h, so remove
> the unnecessary include of it.
>
> Signed-off-by: Bjorn Helgaas <[email protected]>

Not sure you need my ack for something so trivial, but here it is
Acked-by: Jon Mason <[email protected]>

> ---
> drivers/net/ethernet/neterion/vxge/vxge-config.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/neterion/vxge/vxge-config.c b/drivers/net/ethernet/neterion/vxge/vxge-config.c
> index 358ed6118881..a2c0a93ca8b6 100644
> --- a/drivers/net/ethernet/neterion/vxge/vxge-config.c
> +++ b/drivers/net/ethernet/neterion/vxge/vxge-config.c
> @@ -14,7 +14,6 @@
> #include <linux/vmalloc.h>
> #include <linux/etherdevice.h>
> #include <linux/pci.h>
> -#include <linux/pci_hotplug.h>
> #include <linux/slab.h>
>
> #include "vxge-traffic.h"
>

2018-07-25 20:55:26

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] vxge: Remove unnecessary include of <linux/pci_hotplug.h>

From: Bjorn Helgaas <[email protected]>
Date: Mon, 23 Jul 2018 15:59:46 -0500

> From: Bjorn Helgaas <[email protected]>
>
> The vxge driver doesn't need anything provided by pci_hotplug.h, so remove
> the unnecessary include of it.
>
> Signed-off-by: Bjorn Helgaas <[email protected]>

Applied to net-next, thanks.