2018-07-24 11:49:04

by Roman Stratiienko

Subject: [PATCH] mwifiex: Fix skipped vendor specific IEs

From: Roman Stratiienko <[email protected]>

Mwifiex firmware inserts only Microsoft information element
Allow other vendor specific IEs to pass from userspace

Signed-off-by: Roman Stratiienko <[email protected]>
---
drivers/net/wireless/marvell/mwifiex/ie.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/marvell/mwifiex/ie.c b/drivers/net/wireless/marvell/mwifiex/ie.c
index b10baac..75cbd60 100644
--- a/drivers/net/wireless/marvell/mwifiex/ie.c
+++ b/drivers/net/wireless/marvell/mwifiex/ie.c
@@ -355,8 +355,14 @@ static int mwifiex_uap_parse_tail_ies(struct mwifiex_private *priv,
case WLAN_EID_HT_OPERATION:
case WLAN_EID_VHT_CAPABILITY:
case WLAN_EID_VHT_OPERATION:
- case WLAN_EID_VENDOR_SPECIFIC:
break;
+ case WLAN_EID_VENDOR_SPECIFIC:
+ /* Skip only Microsoft WMM IE */
+ if (cfg80211_find_vendor_ie(WLAN_OUI_MICROSOFT,
+ WLAN_OUI_TYPE_MICROSOFT_WMM,
+ (const u8 *)hdr,
+ hdr->len + sizeof(struct ieee_types_header)))
+ break;
default:
memcpy(gen_ie->ie_buffer + ie_len, hdr,
hdr->len + sizeof(struct ieee_types_header));
--
2.7.4

2018-07-31 07:00:15

by Kalle Valo

Subject: Re: [PATCH] mwifiex: Fix skipped vendor specific IEs

[email protected] wrote:

> From: Roman Stratiienko <[email protected]>
>
> Mwifiex firmware inserts only Microsoft information element
> Allow other vendor specific IEs to pass from userspace
>
> Signed-off-by: Roman Stratiienko <[email protected]>

When you submit a new version fo a patch please always add a version number to
the title and include a changelog:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing

But this is for the future, no need to resend this patch.

--
https://patchwork.kernel.org/patch/10541923/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2018-07-31 07:16:15

by Kalle Valo

Subject: Re: [PATCH] mwifiex: Fix skipped vendor specific IEs

[email protected] wrote:

> From: Roman Stratiienko <[email protected]>
>
> Mwifiex firmware inserts only Microsoft information element
> Allow other vendor specific IEs to pass from userspace
>
> Signed-off-by: Roman Stratiienko <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

bfc83ea196ad mwifiex: Fix skipped vendor specific IEs

--
https://patchwork.kernel.org/patch/10541923/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches