From: Alan Chiang <[email protected]>
The RESEND PATCH modifies the commit message and adds the Reviewed-by.
In at24.c, it uses 8-bit addressing by default. In this patch add a
property address-width that provides a flexible method to pass the
information to the driver.
Alan Chiang (2):
dt-bindings: at24: Add address-width property
eeprom: at24: Add support for address-width property
Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
drivers/misc/eeprom/at24.c | 17 +++++++++++++++++
2 files changed, 19 insertions(+)
--
2.7.4
From: Alan Chiang <[email protected]>
Currently the only way to use a variant of a supported model with
a different address with a different address width is to define a
new compatible string and the corresponding chip data structure.
Provide a flexible way to specify the size of the address pointer
by defining a new property: address-width.
Signed-off-by: Alan Chiang <[email protected]>
Signed-off-by: Andy Yeh <[email protected]>
Acked-by: Sakari Ailus <[email protected]>
Reviewed-by: Rob Herring <[email protected]>
---
Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
index 61d833a..aededdb 100644
--- a/Documentation/devicetree/bindings/eeprom/at24.txt
+++ b/Documentation/devicetree/bindings/eeprom/at24.txt
@@ -72,6 +72,8 @@ Optional properties:
- wp-gpios: GPIO to which the write-protect pin of the chip is connected.
+ - address-width: number of address bits (one of 8, 16).
+
Example:
eeprom@52 {
--
2.7.4
From: Alan Chiang <[email protected]>
Provide a flexible way to determine the addressing bits of eeprom.
Pass the addressing bits to driver through address-width property.
Signed-off-by: Alan Chiang <[email protected]>
Signed-off-by: Andy Yeh <[email protected]>
---
drivers/misc/eeprom/at24.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index 0c125f2..7ea640b 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -478,6 +478,23 @@ static void at24_properties_to_pdata(struct device *dev,
if (device_property_present(dev, "no-read-rollover"))
chip->flags |= AT24_FLAG_NO_RDROL;
+ err = device_property_read_u32(dev, "address-width", &val);
+ if (!err) {
+ switch (val) {
+ case 8:
+ if (chip->flags & AT24_FLAG_ADDR16)
+ dev_warn(dev, "Override address width to be 8, while default is 16\n");
+ chip->flags &= ~AT24_FLAG_ADDR16;
+ break;
+ case 16:
+ chip->flags |= AT24_FLAG_ADDR16;
+ break;
+ default:
+ dev_warn(dev, "Bad \"address-width\" property: %u\n",
+ val);
+ }
+ }
+
err = device_property_read_u32(dev, "size", &val);
if (!err)
chip->byte_len = val;
--
2.7.4
2018-07-25 5:20 GMT+02:00 <[email protected]>:
> From: Alan Chiang <[email protected]>
>
> Currently the only way to use a variant of a supported model with
> a different address with a different address width is to define a
There's some copy-paste problem here. I fixed it.
> new compatible string and the corresponding chip data structure.
>
> Provide a flexible way to specify the size of the address pointer
> by defining a new property: address-width.
>
> Signed-off-by: Alan Chiang <[email protected]>
> Signed-off-by: Andy Yeh <[email protected]>
> Acked-by: Sakari Ailus <[email protected]>
> Reviewed-by: Rob Herring <[email protected]>
> ---
> Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
> index 61d833a..aededdb 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.txt
> +++ b/Documentation/devicetree/bindings/eeprom/at24.txt
> @@ -72,6 +72,8 @@ Optional properties:
>
> - wp-gpios: GPIO to which the write-protect pin of the chip is connected.
>
> + - address-width: number of address bits (one of 8, 16).
> +
> Example:
>
> eeprom@52 {
> --
> 2.7.4
>
Applied both to for-next.
Bart