GPLL7 is not on by default, which causes a "gcc_sdcc2_apps_clk_src: rcg
didn't update its configuration" error when booting. Set .flags =
CLK_OPS_PARENT_ENABLE to fix the error.
Fixes: 131abae905df ("clk: qcom: Add SM6350 GCC driver")
Signed-off-by: Luca Weiss <[email protected]>
---
As with sm8250[0], we need the same fix for sm6350 as we have the same
warning on boot. With this patch the warning disappears.
[0] https://lore.kernel.org/linux-arm-msm/[email protected]/
---
drivers/clk/qcom/gcc-sm6350.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/qcom/gcc-sm6350.c b/drivers/clk/qcom/gcc-sm6350.c
index 9b4e4bb05963..cf4a7b6e0b23 100644
--- a/drivers/clk/qcom/gcc-sm6350.c
+++ b/drivers/clk/qcom/gcc-sm6350.c
@@ -641,6 +641,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = {
.name = "gcc_sdcc2_apps_clk_src",
.parent_data = gcc_parent_data_8,
.num_parents = ARRAY_SIZE(gcc_parent_data_8),
+ .flags = CLK_OPS_PARENT_ENABLE,
.ops = &clk_rcg2_floor_ops,
},
};
---
base-commit: fb4327106e5250ee360d0d8b056c1eef7eeb9a98
change-id: 20230804-sm6350-sdcc2-d85cdd01a6e1
Best regards,
--
Luca Weiss <[email protected]>
On 4.08.2023 16:09, Luca Weiss wrote:
> GPLL7 is not on by default, which causes a "gcc_sdcc2_apps_clk_src: rcg
> didn't update its configuration" error when booting. Set .flags =
> CLK_OPS_PARENT_ENABLE to fix the error.
>
> Fixes: 131abae905df ("clk: qcom: Add SM6350 GCC driver")
> Signed-off-by: Luca Weiss <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>
Konrad
On Fri, 04 Aug 2023 16:09:30 +0200, Luca Weiss wrote:
> GPLL7 is not on by default, which causes a "gcc_sdcc2_apps_clk_src: rcg
> didn't update its configuration" error when booting. Set .flags =
> CLK_OPS_PARENT_ENABLE to fix the error.
>
>
Applied, thanks!
[1/1] clk: qcom: gcc-sm6350: Fix gcc_sdcc2_apps_clk_src
commit: df04d166d1f346dbf740bbea64a3bed3e7f14c8d
Best regards,
--
Bjorn Andersson <[email protected]>