2018-07-30 08:53:13

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warning after merge of the nfs-anna tree

Hi all,

After merging the nfs-anna tree, today's linux-next build (powerpc
ppc44x_defconfig, sparc defconfig) produced this warning:

net/sunrpc/stats.c: In function 'rpc_clnt_show_stats':
/home/sfr/next/next/net/sunrpc/stats.c:258:32: warning: excess elements in struct initializer
struct rpc_iostats stats = { 0 };
^

Introduced by commit

c3b588a2d5be ("sunrpc: Change rpc_print_iostats to rpc_clnt_show_stats and handle rpc_clnt clones")

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2018-07-31 09:06:03

by David Wysochanski

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the nfs-anna tree

On Mon, 2018-07-30 at 18:52 +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the nfs-anna tree, today's linux-next build (powerpc
> ppc44x_defconfig, sparc defconfig) produced this warning:
>
> net/sunrpc/stats.c: In function 'rpc_clnt_show_stats':
> /home/sfr/next/next/net/sunrpc/stats.c:258:32: warning: excess elements in struct initializer
> struct rpc_iostats stats = { 0 };
>

Apologies I did not see this before submission.

The below fixup compiles without warning for me on ppc64le.

   struct rpc_iostats stats = {};


> ^
>
> Introduced by commit
>
> c3b588a2d5be ("sunrpc: Change rpc_print_iostats to rpc_clnt_show_stats and handle rpc_clnt clones")
>

2018-07-31 13:48:41

by Anna Schumaker

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the nfs-anna tree

Hi David,

On 07/31/2018 05:04 AM, David Wysochanski wrote:
> On Mon, 2018-07-30 at 18:52 +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the nfs-anna tree, today's linux-next build (powerpc
>> ppc44x_defconfig, sparc defconfig) produced this warning:
>>
>> net/sunrpc/stats.c: In function 'rpc_clnt_show_stats':
>> /home/sfr/next/next/net/sunrpc/stats.c:258:32: warning: excess elements in struct initializer
>> struct rpc_iostats stats = { 0 };
>>
>
> Apologies I did not see this before submission.
>
> The below fixup compiles without warning for me on ppc64le.
>
>    struct rpc_iostats stats = {};

Can you resend the patch with that change, please?

Thanks,
Anna

>
>
>> ^
>>
>> Introduced by commit
>>
>> c3b588a2d5be ("sunrpc: Change rpc_print_iostats to rpc_clnt_show_stats and handle rpc_clnt clones")
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>