2018-08-13 09:40:03

by Sean Fu

Subject: [PATCH] md/bcache: Remove NULL check.

Remove unnessesary NULL check before kmem_cache_destroy() in
drivers/md/bcache/request.c

Signed-off-by: Sean Fu <[email protected]>
---
drivers/md/bcache/request.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
index ae67f5f..0ddee35 100644
--- a/drivers/md/bcache/request.c
+++ b/drivers/md/bcache/request.c
@@ -1306,8 +1306,7 @@ void bch_flash_dev_request_init(struct bcache_device *d)

void bch_request_exit(void)
{
- if (bch_search_cache)
- kmem_cache_destroy(bch_search_cache);
+ kmem_cache_destroy(bch_search_cache);
}

int __init bch_request_init(void)
--
2.6.2

2018-08-13 10:12:37

by Coly Li

Subject: Re: [PATCH] md/bcache: Remove NULL check.

On 2018/8/13 5:38 PM, Sean Fu wrote:
> Remove unnessesary NULL check before kmem_cache_destroy() in
> drivers/md/bcache/request.c
>
> Signed-off-by: Sean Fu <[email protected]>

Hi Sean,

A same change is posted in my previous checkpatch fixes series. You may
find it from,
https://git.kernel.org/pub/scm/linux/kernel/git/colyli/linux-bcache.git/?h=for-next

The identical patch is,
https://git.kernel.org/pub/scm/linux/kernel/git/colyli/linux-bcache.git/commit/?h=for-next&id=26b39d0732955ecb839d0afe8d6211d70f213384

Thanks.

Coly Li

> ---
> drivers/md/bcache/request.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
> index ae67f5f..0ddee35 100644
> --- a/drivers/md/bcache/request.c
> +++ b/drivers/md/bcache/request.c
> @@ -1306,8 +1306,7 @@ void bch_flash_dev_request_init(struct bcache_device *d)
>
> void bch_request_exit(void)
> {
> - if (bch_search_cache)
> - kmem_cache_destroy(bch_search_cache);
> + kmem_cache_destroy(bch_search_cache);
> }
>
> int __init bch_request_init(void)
>

2018-08-14 02:31:37

by Sean Fu

Subject: Re: [PATCH] md/bcache: Remove NULL check.

On Mon, Aug 13, 2018 at 06:00:11PM +0800, Coly Li wrote:
> On 2018/8/13 5:38 PM, Sean Fu wrote:
> > Remove unnessesary NULL check before kmem_cache_destroy() in
> > drivers/md/bcache/request.c
> >
> > Signed-off-by: Sean Fu <[email protected]>
>
> Hi Sean,
>
> A same change is posted in my previous checkpatch fixes series. You may
> find it from,
> https://git.kernel.org/pub/scm/linux/kernel/git/colyli/linux-bcache.git/?h=for-next
>
> The identical patch is,
> https://git.kernel.org/pub/scm/linux/kernel/git/colyli/linux-bcache.git/commit/?h=for-next&id=26b39d0732955ecb839d0afe8d6211d70f213384
>
Thank you for your reply.

Sean Fu
> Thanks.
>
> Coly Li
>
> > ---
> > drivers/md/bcache/request.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
> > index ae67f5f..0ddee35 100644
> > --- a/drivers/md/bcache/request.c
> > +++ b/drivers/md/bcache/request.c
> > @@ -1306,8 +1306,7 @@ void bch_flash_dev_request_init(struct bcache_device *d)
> >
> > void bch_request_exit(void)
> > {
> > - if (bch_search_cache)
> > - kmem_cache_destroy(bch_search_cache);
> > + kmem_cache_destroy(bch_search_cache);
> > }
> >
> > int __init bch_request_init(void)
> >
>