2018-08-21 21:08:19

by Alexey Khoroshilov

Subject: [PATCH] clk: cdce925: release child device nodes

of_get_child_by_name() returns device node with refcount incremented,
but there is no decrement in cdce925_probe(). The patch adds one.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <[email protected]>
---
drivers/clk/clk-cdce925.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clk/clk-cdce925.c b/drivers/clk/clk-cdce925.c
index 0a7e7d5a7506..e9c3ffad4ac3 100644
--- a/drivers/clk/clk-cdce925.c
+++ b/drivers/clk/clk-cdce925.c
@@ -703,6 +703,7 @@ static int cdce925_probe(struct i2c_client *client,
0x12 + (i*CDCE925_OFFSET_PLL),
0x07, value & 0x07);
}
+ of_node_put(np_output);
}

/* Register output clock Y1 */
--
2.7.4

2018-08-30 22:21:45

by Stephen Boyd

Subject: Re: [PATCH] clk: cdce925: release child device nodes

Quoting Alexey Khoroshilov (2018-08-21 14:05:32)
> of_get_child_by_name() returns device node with refcount incremented,
> but there is no decrement in cdce925_probe(). The patch adds one.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <[email protected]>
> ---

Applied to clk-next