2018-08-27 06:37:52

by Sandy Huang

Subject: [PATCH] drm/rockchip: fix coding style and incorrect description

Align with other drivers, tab + 2 space key for description.
and this option should be enabled on both rk3288 and rk3399.

Signed-off-by: Sandy Huang <[email protected]>
---
drivers/gpu/drm/rockchip/Kconfig | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
index 0ccc762..601234b 100644
--- a/drivers/gpu/drm/rockchip/Kconfig
+++ b/drivers/gpu/drm/rockchip/Kconfig
@@ -45,10 +45,10 @@ config ROCKCHIP_DW_HDMI
config ROCKCHIP_DW_MIPI_DSI
bool "Rockchip specific extensions for Synopsys DW MIPI DSI"
help
- This selects support for Rockchip SoC specific extensions
- for the Synopsys DesignWare HDMI driver. If you want to
- enable MIPI DSI on RK3288 based SoC, you should selet this
- option.
+ This selects support for Rockchip SoC specific extensions
+ for the Synopsys DesignWare HDMI driver. If you want to
+ enable MIPI DSI on RK3288 or RK3399 based SoC, you should
+ selet this option.

config ROCKCHIP_INNO_HDMI
bool "Rockchip specific extensions for Innosilicon HDMI"
--
2.7.4

2018-08-27 07:04:27

by Enric Balletbo Serra

Subject: Re: [PATCH] drm/rockchip: fix coding style and incorrect description

Hi Sandy,

Just noticed a typo that I think will be good fix also
Missatge de Sandy Huang <[email protected]> del dia dl., 27 d’ag.
2018 a les 8:31:
>
> Align with other drivers, tab + 2 space key for description.
> and this option should be enabled on both rk3288 and rk3399.
>
> Signed-off-by: Sandy Huang <[email protected]>
> ---
> drivers/gpu/drm/rockchip/Kconfig | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
> index 0ccc762..601234b 100644
> --- a/drivers/gpu/drm/rockchip/Kconfig
> +++ b/drivers/gpu/drm/rockchip/Kconfig
> @@ -45,10 +45,10 @@ config ROCKCHIP_DW_HDMI
> config ROCKCHIP_DW_MIPI_DSI
> bool "Rockchip specific extensions for Synopsys DW MIPI DSI"
> help
> - This selects support for Rockchip SoC specific extensions
> - for the Synopsys DesignWare HDMI driver. If you want to
> - enable MIPI DSI on RK3288 based SoC, you should selet this
> - option.
> + This selects support for Rockchip SoC specific extensions
> + for the Synopsys DesignWare HDMI driver. If you want to
> + enable MIPI DSI on RK3288 or RK3399 based SoC, you should
> + selet this option.

s/selet/select/

Cheers,
Enric

>
> config ROCKCHIP_INNO_HDMI
> bool "Rockchip specific extensions for Innosilicon HDMI"
> --
> 2.7.4
>
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

2018-08-28 07:49:31

by Sandy Huang

Subject: Re: [PATCH] drm/rockchip: fix coding style and incorrect description

Hi enric,
    thanks, this will be upated at v2 patch.

在 2018/8/27 15:02, Enric Balletbo Serra 写道:
> Hi Sandy,
>
> Just noticed a typo that I think will be good fix also
> Missatge de Sandy Huang <[email protected]> del dia dl., 27 d’ag.
> 2018 a les 8:31:
> >
> > Align with other drivers, tab + 2 space key for description.
> > and this option should be enabled on both rk3288 and rk3399.
> >
> > Signed-off-by: Sandy Huang <[email protected]>
> > ---
> >   drivers/gpu/drm/rockchip/Kconfig | 8 ++++----
> >   1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
> > index 0ccc762..601234b 100644
> > --- a/drivers/gpu/drm/rockchip/Kconfig
> > +++ b/drivers/gpu/drm/rockchip/Kconfig
> > @@ -45,10 +45,10 @@ config ROCKCHIP_DW_HDMI
> >   config ROCKCHIP_DW_MIPI_DSI
> >          bool "Rockchip specific extensions for Synopsys DW MIPI DSI"
> >          help
> > -        This selects support for Rockchip SoC specific extensions
> > -        for the Synopsys DesignWare HDMI driver. If you want to
> > -        enable MIPI DSI on RK3288 based SoC, you should selet this
> > -        option.
> > +         This selects support for Rockchip SoC specific extensions
> > +         for the Synopsys DesignWare HDMI driver. If you want to
> > +         enable MIPI DSI on RK3288 or RK3399 based SoC, you should
> > +         selet this option.
>
> s/selet/select/
>
> Cheers,
>   Enric
>
> >
> >   config ROCKCHIP_INNO_HDMI
> >          bool "Rockchip specific extensions for Innosilicon HDMI"
> > --
> > 2.7.4
> >
> >
> > _______________________________________________
> > dri-devel mailing list
> > [email protected]
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>
>