2018-08-28 07:47:50

by Sandy Huang

[permalink] [raw]
Subject: [PATCH v2] drm/rockchip: fix coding style and incorrect description

Align with other drivers, tab + 2 space key for description.
and edp/hdmi/dsi can be used on both rk3288 and rk3399.

Signed-off-by: Sandy Huang <[email protected]>
---
drivers/gpu/drm/rockchip/Kconfig | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
index 0ccc762..0534dc1 100644
--- a/drivers/gpu/drm/rockchip/Kconfig
+++ b/drivers/gpu/drm/rockchip/Kconfig
@@ -23,7 +23,7 @@ config ROCKCHIP_ANALOGIX_DP
help
This selects support for Rockchip SoC specific extensions
for the Analogix Core DP driver. If you want to enable DP
- on RK3288 based SoC, you should selet this option.
+ on RK3288 or RK3399 based SoC, you should select this option.

config ROCKCHIP_CDN_DP
bool "Rockchip cdn DP"
@@ -39,16 +39,16 @@ config ROCKCHIP_DW_HDMI
help
This selects support for Rockchip SoC specific extensions
for the Synopsys DesignWare HDMI driver. If you want to
- enable HDMI on RK3288 based SoC, you should selet this
- option.
+ enable HDMI on RK3288 or RK3399 based SoC, you should select
+ this option.

config ROCKCHIP_DW_MIPI_DSI
bool "Rockchip specific extensions for Synopsys DW MIPI DSI"
help
- This selects support for Rockchip SoC specific extensions
- for the Synopsys DesignWare HDMI driver. If you want to
- enable MIPI DSI on RK3288 based SoC, you should selet this
- option.
+ This selects support for Rockchip SoC specific extensions
+ for the Synopsys DesignWare HDMI driver. If you want to
+ enable MIPI DSI on RK3288 or RK3399 based SoC, you should
+ select this option.

config ROCKCHIP_INNO_HDMI
bool "Rockchip specific extensions for Innosilicon HDMI"
--
2.7.4




2018-08-28 08:22:25

by Enric Balletbo Serra

[permalink] [raw]
Subject: Re: [PATCH v2] drm/rockchip: fix coding style and incorrect description

Missatge de Sandy Huang <[email protected]> del dia dt., 28 d’ag.
2018 a les 9:45:
>
> Align with other drivers, tab + 2 space key for description.
> and edp/hdmi/dsi can be used on both rk3288 and rk3399.
>
> Signed-off-by: Sandy Huang <[email protected]>
> ---
> drivers/gpu/drm/rockchip/Kconfig | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
> index 0ccc762..0534dc1 100644
> --- a/drivers/gpu/drm/rockchip/Kconfig
> +++ b/drivers/gpu/drm/rockchip/Kconfig
> @@ -23,7 +23,7 @@ config ROCKCHIP_ANALOGIX_DP
> help
> This selects support for Rockchip SoC specific extensions
> for the Analogix Core DP driver. If you want to enable DP
> - on RK3288 based SoC, you should selet this option.
> + on RK3288 or RK3399 based SoC, you should select this option.
>
> config ROCKCHIP_CDN_DP
> bool "Rockchip cdn DP"
> @@ -39,16 +39,16 @@ config ROCKCHIP_DW_HDMI
> help
> This selects support for Rockchip SoC specific extensions
> for the Synopsys DesignWare HDMI driver. If you want to
> - enable HDMI on RK3288 based SoC, you should selet this
> - option.
> + enable HDMI on RK3288 or RK3399 based SoC, you should select
> + this option.
>
> config ROCKCHIP_DW_MIPI_DSI
> bool "Rockchip specific extensions for Synopsys DW MIPI DSI"
> help
> - This selects support for Rockchip SoC specific extensions
> - for the Synopsys DesignWare HDMI driver. If you want to
> - enable MIPI DSI on RK3288 based SoC, you should selet this
> - option.
> + This selects support for Rockchip SoC specific extensions
> + for the Synopsys DesignWare HDMI driver. If you want to
> + enable MIPI DSI on RK3288 or RK3399 based SoC, you should
> + select this option.
>
> config ROCKCHIP_INNO_HDMI
> bool "Rockchip specific extensions for Innosilicon HDMI"
> --
> 2.7.4

If it helps...

Reviewed-by: Enric Balletbo i Serra <[email protected]>

>
>

2018-08-29 11:21:18

by Heiko Stübner

[permalink] [raw]
Subject: Re: [PATCH v2] drm/rockchip: fix coding style and incorrect description

Am Dienstag, 28. August 2018, 09:44:55 CEST schrieb Sandy Huang:
> Align with other drivers, tab + 2 space key for description.
> and edp/hdmi/dsi can be used on both rk3288 and rk3399.
>
> Signed-off-by: Sandy Huang <[email protected]>

applied to drm-misc