2018-08-28 14:59:30

by Liu Xiang

Subject: [PATCH v3] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB

If the size of spi-nor flash is larger than 16MB, the read_opcode
is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will
return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can
cause read operation fail.

Fixes: e46ecda764dc ("mtd: spi-nor: Add Freescale QuadSPI driver")
Cc: <[email protected]>
Signed-off-by: Liu Xiang <[email protected]>
---

Changes in v3:
move changelog position.

drivers/mtd/spi-nor/fsl-quadspi.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
index 7d9620c..64304a3 100644
--- a/drivers/mtd/spi-nor/fsl-quadspi.c
+++ b/drivers/mtd/spi-nor/fsl-quadspi.c
@@ -478,6 +478,7 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd)
{
switch (cmd) {
case SPINOR_OP_READ_1_1_4:
+ case SPINOR_OP_READ_1_1_4_4B:
return SEQID_READ;
case SPINOR_OP_WREN:
return SEQID_WREN;
--
1.9.1

2018-08-28 14:39:57

by Boris Brezillon

Subject: Re: [PATCH v3] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB

On Tue, 28 Aug 2018 22:32:57 +0800
Liu Xiang <[email protected]> wrote:

> If the size of spi-nor flash is larger than 16MB, the read_opcode
> is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will
> return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can
> cause read operation fail.
>
> Fixes: e46ecda764dc ("mtd: spi-nor: Add Freescale QuadSPI driver")
> Cc: <[email protected]>
> Signed-off-by: Liu Xiang <[email protected]>
> ---
>
> Changes in v3:
> move changelog position.

Normally you should keep the v2 changelog here. No need to resend just
for that.

>
> drivers/mtd/spi-nor/fsl-quadspi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
> index 7d9620c..64304a3 100644
> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
> @@ -478,6 +478,7 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd)
> {
> switch (cmd) {
> case SPINOR_OP_READ_1_1_4:
> + case SPINOR_OP_READ_1_1_4_4B:
> return SEQID_READ;
> case SPINOR_OP_WREN:
> return SEQID_WREN;

2018-10-12 12:48:16

by Boris Brezillon

Subject: Re: [PATCH v3] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB

On Tue, 28 Aug 2018 22:32:57 +0800
Liu Xiang <[email protected]> wrote:

> If the size of spi-nor flash is larger than 16MB, the read_opcode
> is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will
> return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can
> cause read operation fail.
>
> Fixes: e46ecda764dc ("mtd: spi-nor: Add Freescale QuadSPI driver")
> Cc: <[email protected]>
> Signed-off-by: Liu Xiang <[email protected]>

Queued to spi-nor/next.

Thanks,

Boris

> ---
>
> Changes in v3:
> move changelog position.
>
> drivers/mtd/spi-nor/fsl-quadspi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
> index 7d9620c..64304a3 100644
> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
> @@ -478,6 +478,7 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd)
> {
> switch (cmd) {
> case SPINOR_OP_READ_1_1_4:
> + case SPINOR_OP_READ_1_1_4_4B:
> return SEQID_READ;
> case SPINOR_OP_WREN:
> return SEQID_WREN;