2018-09-05 09:58:14

by Lei Yang

Subject: [PATCH] selftests: memory-hotplug: add required configs

add CONFIG_MEMORY_HOTREMOVE=y in config
without this config, /sys/devices/system/memory/memory*/removable
always return 0, I endup getting an early skip during test

Signed-off-by: Lei Yang <[email protected]>
---
tools/testing/selftests/memory-hotplug/config | 1 +
1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/memory-hotplug/config b/tools/testing/selftests/memory-hotplug/config
index 2fde301..a7e8cd5 100644
--- a/tools/testing/selftests/memory-hotplug/config
+++ b/tools/testing/selftests/memory-hotplug/config
@@ -2,3 +2,4 @@ CONFIG_MEMORY_HOTPLUG=y
CONFIG_MEMORY_HOTPLUG_SPARSE=y
CONFIG_NOTIFIER_ERROR_INJECTION=y
CONFIG_MEMORY_NOTIFIER_ERROR_INJECT=m
+CONFIG_MEMORY_HOTREMOVE=y
--
1.9.1

2018-09-05 16:59:50

by Shuah Khan

Subject: Re: [PATCH] selftests: memory-hotplug: add required configs

On 09/05/2018 03:57 AM, Lei Yang wrote:
> add CONFIG_MEMORY_HOTREMOVE=y in config
> without this config, /sys/devices/system/memory/memory*/removable
> always return 0, I endup getting an early skip during test
>
> Signed-off-by: Lei Yang <[email protected]>
> ---
> tools/testing/selftests/memory-hotplug/config | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/memory-hotplug/config b/tools/testing/selftests/memory-hotplug/config
> index 2fde301..a7e8cd5 100644
> --- a/tools/testing/selftests/memory-hotplug/config
> +++ b/tools/testing/selftests/memory-hotplug/config
> @@ -2,3 +2,4 @@ CONFIG_MEMORY_HOTPLUG=y
> CONFIG_MEMORY_HOTPLUG_SPARSE=y
> CONFIG_NOTIFIER_ERROR_INJECTION=y
> CONFIG_MEMORY_NOTIFIER_ERROR_INJECT=m
> +CONFIG_MEMORY_HOTREMOVE=y
>

Thanks. Applied to linux-kselftest next

-- Shuah