2018-09-05 14:57:59

by Christian Hewitt

Subject: [PATCH] usb: dwc2: disable power_down on Amlogic devices

USB devices work when connected to Amlogic GXBB hardware before power
on, but not when connected after boot (hotplugged). With this patch
hotplugging works again. This change was copied from the Rockchip
patch here: (https://marc.info/?l=linux-usb&m=153205711616460&w=2)

Signed-off-by: Christian Hewitt <[email protected]>
---
drivers/usb/dwc2/params.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index bf7052e..93561a2 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -110,6 +110,7 @@ static void dwc2_set_amlogic_params(struct dwc2_hsotg *hsotg)
p->phy_type = DWC2_PHY_TYPE_PARAM_UTMI;
p->ahbcfg = GAHBCFG_HBSTLEN_INCR8 <<
GAHBCFG_HBSTLEN_SHIFT;
+ p->power_down = false;
}

static void dwc2_set_amcc_params(struct dwc2_hsotg *hsotg)
--
2.7.4

2018-09-06 08:39:00

by Minas Harutyunyan

Subject: Re: [PATCH] usb: dwc2: disable power_down on Amlogic devices

On 9/5/2018 6:56 PM, Christian Hewitt wrote:
> USB devices work when connected to Amlogic GXBB hardware before power
> on, but not when connected after boot (hotplugged). With this patch
> hotplugging works again. This change was copied from the Rockchip
> patch here: (https://urldefense.proofpoint.com/v2/url?u=https-3A__marc.info_-3Fl-3Dlinux-2Dusb-26m-3D153205711616460-26w-3D2&d=DwIBAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=cQBKt4q-qzNVC53rNAwuwplH23V61rHQhhULvdLA0U8&m=m5T_SsLG-_isQDyjrHuiVqJWdEqZ21Lcr70lObiPwrg&s=D26wJzWeREBz6_XcmdTqo8k69mPRqGaIbRWl_77Ns3c&e=)
>
> Signed-off-by: Christian Hewitt <[email protected]>

Acked-by: Minas Harutyunyan <[email protected]>

> ---
> drivers/usb/dwc2/params.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index bf7052e..93561a2 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -110,6 +110,7 @@ static void dwc2_set_amlogic_params(struct dwc2_hsotg *hsotg)
> p->phy_type = DWC2_PHY_TYPE_PARAM_UTMI;
> p->ahbcfg = GAHBCFG_HBSTLEN_INCR8 <<
> GAHBCFG_HBSTLEN_SHIFT;
> + p->power_down = false;
> }
>
> static void dwc2_set_amcc_params(struct dwc2_hsotg *hsotg)
>