2018-09-07 05:36:46

by Frank Rowand

[permalink] [raw]
Subject: [PATCH] ARM: qcom_defconfig: Enable MAILBOX

From: Frank Rowand <[email protected]>

Problem:
ab460a2e72da ("rpmsg: qcom_smd: Access APCS through mailbox framework"
added a "depends on MAILBOX") to RPMSG_QCOM_SMD, thus RPMSG_QCOM_SMD
becomes unset since MAILBOX was not enabled in qcom_defconfig and is
not otherwise selected for the dragonboard. When the resulting
kernel is booted the mmc device which contains the root file system
is not available.

Fix:
add CONFIG_MAILBOX to qcom_defconfig

Fixes: ab460a2e72da ("rpmsg: qcom_smd: Access APCS through mailbox framework"
added a "depends on MAILBOX")

Signed-off-by: Frank Rowand <[email protected]>
---

Bjorn suggested that multi_v7_defconfig might need this same fix
but I don't have a target to test on so I have not included that
change in this patch

Tested on Qualcomm APQ8074 Dragonboard

arch/arm/configs/qcom_defconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/qcom_defconfig b/arch/arm/configs/qcom_defconfig
index 6aa7046fb91f..bd6440f23493 100644
--- a/arch/arm/configs/qcom_defconfig
+++ b/arch/arm/configs/qcom_defconfig
@@ -207,6 +207,7 @@ CONFIG_MSM_MMCC_8974=y
CONFIG_MSM_IOMMU=y
CONFIG_HWSPINLOCK=y
CONFIG_HWSPINLOCK_QCOM=y
+CONFIG_MAILBOX=y
CONFIG_REMOTEPROC=y
CONFIG_QCOM_ADSP_PIL=y
CONFIG_QCOM_Q6V5_PIL=y
--
Frank Rowand <[email protected]>



2018-09-07 16:48:52

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] ARM: qcom_defconfig: Enable MAILBOX

On Thu 06 Sep 21:44 PDT 2018, [email protected] wrote:

> From: Frank Rowand <[email protected]>
>
> Problem:
> ab460a2e72da ("rpmsg: qcom_smd: Access APCS through mailbox framework"
> added a "depends on MAILBOX") to RPMSG_QCOM_SMD, thus RPMSG_QCOM_SMD
> becomes unset since MAILBOX was not enabled in qcom_defconfig and is
> not otherwise selected for the dragonboard. When the resulting
> kernel is booted the mmc device which contains the root file system
> is not available.
>
> Fix:
> add CONFIG_MAILBOX to qcom_defconfig
>
> Fixes: ab460a2e72da ("rpmsg: qcom_smd: Access APCS through mailbox framework"
> added a "depends on MAILBOX")
>
> Signed-off-by: Frank Rowand <[email protected]>

Reviewed-by: Bjorn Andersson <[email protected]>

> ---
>
> Bjorn suggested that multi_v7_defconfig might need this same fix
> but I don't have a target to test on so I have not included that
> change in this patch
>

multi_v7_defconfig should boot on 8974 as well, but I would not be a
surprise if there are other things missing there.

Regards,
Bjorn

> Tested on Qualcomm APQ8074 Dragonboard
>
> arch/arm/configs/qcom_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/qcom_defconfig b/arch/arm/configs/qcom_defconfig
> index 6aa7046fb91f..bd6440f23493 100644
> --- a/arch/arm/configs/qcom_defconfig
> +++ b/arch/arm/configs/qcom_defconfig
> @@ -207,6 +207,7 @@ CONFIG_MSM_MMCC_8974=y
> CONFIG_MSM_IOMMU=y
> CONFIG_HWSPINLOCK=y
> CONFIG_HWSPINLOCK_QCOM=y
> +CONFIG_MAILBOX=y
> CONFIG_REMOTEPROC=y
> CONFIG_QCOM_ADSP_PIL=y
> CONFIG_QCOM_Q6V5_PIL=y
> --
> Frank Rowand <[email protected]>
>