2018-09-17 06:15:41

by zhong jiang

Subject: [PATCH] x86/apm: Fix a unused function warning

Fix the following compile warning:

arch/x86/kernel/apm_32.c:1643:12: warning: ‘proc_apm_show’ defined but not used [-Wunused-function]
static int proc_apm_show(struct seq_file *m, void *v)

Signed-off-by: zhong jiang <[email protected]>
---
arch/x86/kernel/apm_32.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/x86/kernel/apm_32.c b/arch/x86/kernel/apm_32.c
index ec00d1f..f7151cd 100644
--- a/arch/x86/kernel/apm_32.c
+++ b/arch/x86/kernel/apm_32.c
@@ -1640,6 +1640,7 @@ static int do_open(struct inode *inode, struct file *filp)
return 0;
}

+#ifdef CONFIG_PROC_FS
static int proc_apm_show(struct seq_file *m, void *v)
{
unsigned short bx;
@@ -1719,6 +1720,7 @@ static int proc_apm_show(struct seq_file *m, void *v)
units);
return 0;
}
+#endif

static int apm(void *unused)
{
--
1.7.12.4

2018-09-17 09:24:48

by Thomas Gleixner

Subject: Re: [PATCH] x86/apm: Fix a unused function warning

On Mon, 17 Sep 2018, zhong jiang wrote:

> Fix the following compile warning:
>
> arch/x86/kernel/apm_32.c:1643:12: warning: ?proc_apm_show? defined but not used [-Wunused-function]
> static int proc_apm_show(struct seq_file *m, void *v)

Thanks for taking care, but it's already fixed the same way with:

002b87d2aace ("x86/APM: Fix build warning when PROC_FS is not enabled")

Thanks,

tglx

2018-09-17 09:41:41

by zhong jiang

Subject: Re: [PATCH] x86/apm: Fix a unused function warning

On 2018/9/17 17:24, Thomas Gleixner wrote:
> On Mon, 17 Sep 2018, zhong jiang wrote:
>
>> Fix the following compile warning:
>>
>> arch/x86/kernel/apm_32.c:1643:12: warning: ?proc_apm_show? defined but not used [-Wunused-function]
>> static int proc_apm_show(struct seq_file *m, void *v)
> Thanks for taking care, but it's already fixed the same way with:
>
> 002b87d2aace ("x86/APM: Fix build warning when PROC_FS is not enabled")
Fine. Thanks for let me know that. I has missed that.

Thanks,
zhong jiang
> Thanks,
>
> tglx
>
> .
>