2018-09-26 11:54:14

by zhong jiang

Subject: [PATCH] misc: cxl: Move a deference below a NULL test

It is safe to move a deference below a NULL test.

Signed-off-by: zhong jiang <[email protected]>
---
drivers/misc/cxl/guest.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c
index 3bc0c15..559e835 100644
--- a/drivers/misc/cxl/guest.c
+++ b/drivers/misc/cxl/guest.c
@@ -1018,11 +1018,11 @@ int cxl_guest_init_afu(struct cxl *adapter, int slice, struct device_node *afu_n

void cxl_guest_remove_afu(struct cxl_afu *afu)
{
- pr_devel("in %s - AFU(%d)\n", __func__, afu->slice);
-
if (!afu)
return;

+ pr_devel("in %s - AFU(%d)\n", __func__, afu->slice);
+
/* flush and stop pending job */
afu->guest->handle_err = false;
flush_delayed_work(&afu->guest->work_err);
--
1.7.12.4

2018-09-26 23:46:48

by Andrew Donnellan

Subject: Re: [PATCH] misc: cxl: Move a deference below a NULL test

On 26/9/18 9:41 pm, zhong jiang wrote:
> It is safe to move a deference below a NULL test.
>
> Signed-off-by: zhong jiang <[email protected]>

Thanks for catching this.

Acked-by: Andrew Donnellan <[email protected]>

> ---
> drivers/misc/cxl/guest.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c
> index 3bc0c15..559e835 100644
> --- a/drivers/misc/cxl/guest.c
> +++ b/drivers/misc/cxl/guest.c
> @@ -1018,11 +1018,11 @@ int cxl_guest_init_afu(struct cxl *adapter, int slice, struct device_node *afu_n
>
> void cxl_guest_remove_afu(struct cxl_afu *afu)
> {
> - pr_devel("in %s - AFU(%d)\n", __func__, afu->slice);
> -
> if (!afu)
> return;
>
> + pr_devel("in %s - AFU(%d)\n", __func__, afu->slice);
> +
> /* flush and stop pending job */
> afu->guest->handle_err = false;
> flush_delayed_work(&afu->guest->work_err);
>

--
Andrew Donnellan OzLabs, ADL Canberra
[email protected] IBM Australia Limited

2018-10-02 22:56:23

by Greg Kroah-Hartman

Subject: Re: [PATCH] misc: cxl: Move a deference below a NULL test

On Wed, Sep 26, 2018 at 07:41:12PM +0800, zhong jiang wrote:
> It is safe to move a deference below a NULL test.
>
> Signed-off-by: zhong jiang <[email protected]>
> Acked-by: Andrew Donnellan <[email protected]>
> ---
> drivers/misc/cxl/guest.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c
> index 3bc0c15..559e835 100644
> --- a/drivers/misc/cxl/guest.c
> +++ b/drivers/misc/cxl/guest.c
> @@ -1018,11 +1018,11 @@ int cxl_guest_init_afu(struct cxl *adapter, int slice, struct device_node *afu_n
>
> void cxl_guest_remove_afu(struct cxl_afu *afu)
> {
> - pr_devel("in %s - AFU(%d)\n", __func__, afu->slice);
> -
> if (!afu)
> return;
>
> + pr_devel("in %s - AFU(%d)\n", __func__, afu->slice);
> +

This call should just be deleted, ftrace can be used if this type of
thing is really needed.

thanks,

greg k-h

2018-10-04 02:45:41

by zhong jiang

Subject: Re: [PATCH] misc: cxl: Move a deference below a NULL test

On 2018/10/3 6:55, Greg KH wrote:
> On Wed, Sep 26, 2018 at 07:41:12PM +0800, zhong jiang wrote:
>> It is safe to move a deference below a NULL test.
>>
>> Signed-off-by: zhong jiang <[email protected]>
>> Acked-by: Andrew Donnellan <[email protected]>
>> ---
>> drivers/misc/cxl/guest.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c
>> index 3bc0c15..559e835 100644
>> --- a/drivers/misc/cxl/guest.c
>> +++ b/drivers/misc/cxl/guest.c
>> @@ -1018,11 +1018,11 @@ int cxl_guest_init_afu(struct cxl *adapter, int slice, struct device_node *afu_n
>>
>> void cxl_guest_remove_afu(struct cxl_afu *afu)
>> {
>> - pr_devel("in %s - AFU(%d)\n", __func__, afu->slice);
>> -
>> if (!afu)
>> return;
>>
>> + pr_devel("in %s - AFU(%d)\n", __func__, afu->slice);
>> +
> This call should just be deleted, ftrace can be used if this type of
> thing is really needed.
Ok, just delete the dereference in advance. Will repost in v2.

Thanks,
zhong jiang
> thanks,
>
> greg k-h
>
> .
>