2018-10-19 04:51:26

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warning after merge of the scsi tree

Hi James,

After merging the scsi tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/lpfc/lpfc_debugfs.c: In function 'lpfc_debugfs_nodelist_open':
drivers/scsi/lpfc/lpfc_debugfs.c:706:17: warning: 'nrport' may be used uninitialized in this function [-Wmaybe-uninitialized]
switch (nrport->port_state) {
~~~~~~^~~~~~~~~~~~
drivers/scsi/lpfc/lpfc_debugfs.c:553:30: note: 'nrport' was declared here
struct nvme_fc_remote_port *nrport;
^~~~~~

I am not sure where this has come from :-(

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2018-10-19 04:54:48

by James Bottomley

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the scsi tree

On Fri, 2018-10-19 at 15:50 +1100, Stephen Rothwell wrote:
> Hi James,
>
> After merging the scsi tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> drivers/scsi/lpfc/lpfc_debugfs.c: In function
> 'lpfc_debugfs_nodelist_open':
> drivers/scsi/lpfc/lpfc_debugfs.c:706:17: warning: 'nrport' may be
> used uninitialized in this function [-Wmaybe-uninitialized]
> switch (nrport->port_state) {
> ~~~~~~^~~~~~~~~~~~
> drivers/scsi/lpfc/lpfc_debugfs.c:553:30: note: 'nrport' was declared
> here
> struct nvme_fc_remote_port *nrport;
> ^~~~~~
>
> I am not sure where this has come from :-(

It's the merge commit ... it was obviously the wrong choice; I'll fix
it.

James


Attachments:
signature.asc (235.00 B)
This is a digitally signed message part

2018-10-19 04:58:43

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the scsi tree

Hi James,

On Thu, 18 Oct 2018 21:54:03 -0700 James Bottomley <[email protected]> wrote:
>
> It's the merge commit ... it was obviously the wrong choice; I'll fix
> it.

OK, thanks.

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature