Greeting's
mainline build fails on my powerpc with commit 55469b : drivers: net:
remove <net/busy_poll.h> inclusion when not needed
Machine type: PowerPC power 8 bare-metal
kernel : 4.19.0
gcc : 4.8.5
config attached
build errors:
drivers/net/ethernet/mellanox/mlx4/en_rx.c:582:18: warning: ‘struct
iphdr’ declared inside parameter list [enabled by default]
struct iphdr *iph)
^
drivers/net/ethernet/mellanox/mlx4/en_rx.c:582:18: warning: its scope is
only this definition or declaration, which is probably not what you want
[enabled by default]
drivers/net/ethernet/mellanox/mlx4/en_rx.c: In function
‘get_fixed_ipv4_csum’:
drivers/net/ethernet/mellanox/mlx4/en_rx.c:586:20: error: dereferencing
pointer to incomplete type
__u8 ipproto = iph->protocol;
^
Kernel builds fine when the patch is reverted.
--
Regard's
Abdul Haleem
IBM Linux Technology Centre
On Mon, Oct 29, 2018 at 11:43 PM Abdul Haleem
<[email protected]> wrote:
>
> Greeting's
>
> mainline build fails on my powerpc with commit 55469b : drivers: net:
> remove <net/busy_poll.h> inclusion when not needed
>
> Machine type: PowerPC power 8 bare-metal
> kernel : 4.19.0
> gcc : 4.8.5
> config attached
>
Thanks for the report, but this patch is not in 4.19 kernel ? It is
scheduled for 4.20 only.
Anyway, mlx4 needs to include <net/ip.h> directly, instead of
assuming it is indirectly included by another file.