2018-11-02 14:05:10

by Liam Merwick

[permalink] [raw]
Subject: [PATCH] xen/grant-table: Fix incorrect gnttab_dma_free_pages() pr_debug message

If a call to xenmem_reservation_increase() in gnttab_dma_free_pages()
fails it triggers a message "Failed to decrease reservation..." which
should be "Failed to increase reservation..."

Fixes: 9bdc7304f536 ('xen/grant-table: Allow allocating buffers suitable for DMA')
Reported-by: Ross Philipson <[email protected]>
Signed-off-by: Liam Merwick <[email protected]>
Reviewed-by: Mark Kanda <[email protected]>
---
drivers/xen/grant-table.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c
index 84575baceebc..97341fa75458 100644
--- a/drivers/xen/grant-table.c
+++ b/drivers/xen/grant-table.c
@@ -914,7 +914,7 @@ int gnttab_dma_free_pages(struct gnttab_dma_alloc_args *args)

ret = xenmem_reservation_increase(args->nr_pages, args->frames);
if (ret != args->nr_pages) {
- pr_debug("Failed to decrease reservation for DMA buffer\n");
+ pr_debug("Failed to increase reservation for DMA buffer\n");
ret = -EFAULT;
} else {
ret = 0;
--
1.8.3.1



2018-11-02 15:36:20

by Juergen Gross

[permalink] [raw]
Subject: Re: [PATCH] xen/grant-table: Fix incorrect gnttab_dma_free_pages() pr_debug message

On 02/11/2018 15:04, Liam Merwick wrote:
> If a call to xenmem_reservation_increase() in gnttab_dma_free_pages()
> fails it triggers a message "Failed to decrease reservation..." which
> should be "Failed to increase reservation..."
>
> Fixes: 9bdc7304f536 ('xen/grant-table: Allow allocating buffers suitable for DMA')
> Reported-by: Ross Philipson <[email protected]>
> Signed-off-by: Liam Merwick <[email protected]>
> Reviewed-by: Mark Kanda <[email protected]>

Reviewed-by: Juergen Gross <[email protected]>


Juergen

2018-11-06 09:37:25

by Juergen Gross

[permalink] [raw]
Subject: Re: [PATCH] xen/grant-table: Fix incorrect gnttab_dma_free_pages() pr_debug message

On 02/11/2018 15:04, Liam Merwick wrote:
> If a call to xenmem_reservation_increase() in gnttab_dma_free_pages()
> fails it triggers a message "Failed to decrease reservation..." which
> should be "Failed to increase reservation..."
>
> Fixes: 9bdc7304f536 ('xen/grant-table: Allow allocating buffers suitable for DMA')
> Reported-by: Ross Philipson <[email protected]>
> Signed-off-by: Liam Merwick <[email protected]>
> Reviewed-by: Mark Kanda <[email protected]>

Pushed to xen.git for-linus-4.20a


Juergen