2018-11-12 07:47:06

by Wen Pu

Subject: [RFC PATCH RESEND] tools/perf: Add Hygon Dhyana support

The tool perf is useful for the performance analysis on the Hygon Dhyana
platform. But right now there is no Hygon support for it to analyze the
KVM guest os data. So add Hygon Dhyana support to it by checking vendor
string to share the code path of AMD.

Signed-off-by: Pu Wen <[email protected]>
---
tools/perf/arch/x86/util/kvm-stat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/arch/x86/util/kvm-stat.c b/tools/perf/arch/x86/util/kvm-stat.c
index b32409a..081353d 100644
--- a/tools/perf/arch/x86/util/kvm-stat.c
+++ b/tools/perf/arch/x86/util/kvm-stat.c
@@ -156,7 +156,7 @@ int cpu_isa_init(struct perf_kvm_stat *kvm, const char *cpuid)
if (strstr(cpuid, "Intel")) {
kvm->exit_reasons = vmx_exit_reasons;
kvm->exit_reasons_isa = "VMX";
- } else if (strstr(cpuid, "AMD")) {
+ } else if (strstr(cpuid, "AMD") || strstr(cpuid, "Hygon")) {
kvm->exit_reasons = svm_exit_reasons;
kvm->exit_reasons_isa = "SVM";
} else
--
2.7.4

2018-11-12 11:10:01

by Borislav Petkov

Subject: Re: [RFC PATCH RESEND] tools/perf: Add Hygon Dhyana support

On Mon, Nov 12, 2018 at 03:40:51PM +0800, Pu Wen wrote:
> The tool perf is useful for the performance analysis on the Hygon Dhyana
> platform. But right now there is no Hygon support for it to analyze the
> KVM guest os data. So add Hygon Dhyana support to it by checking vendor

acme, pls fix that to "OS" when applying. Thx.

> string to share the code path of AMD.
>
> Signed-off-by: Pu Wen <[email protected]>
> ---
> tools/perf/arch/x86/util/kvm-stat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Borislav Petkov <[email protected]>

> diff --git a/tools/perf/arch/x86/util/kvm-stat.c b/tools/perf/arch/x86/util/kvm-stat.c
> index b32409a..081353d 100644
> --- a/tools/perf/arch/x86/util/kvm-stat.c
> +++ b/tools/perf/arch/x86/util/kvm-stat.c
> @@ -156,7 +156,7 @@ int cpu_isa_init(struct perf_kvm_stat *kvm, const char *cpuid)
> if (strstr(cpuid, "Intel")) {
> kvm->exit_reasons = vmx_exit_reasons;
> kvm->exit_reasons_isa = "VMX";
> - } else if (strstr(cpuid, "AMD")) {
> + } else if (strstr(cpuid, "AMD") || strstr(cpuid, "Hygon")) {
> kvm->exit_reasons = svm_exit_reasons;
> kvm->exit_reasons_isa = "SVM";
> } else
> --
> 2.7.4
>

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

2018-11-12 16:31:23

by Arnaldo Carvalho de Melo

Subject: Re: [RFC PATCH RESEND] tools/perf: Add Hygon Dhyana support

Em Mon, Nov 12, 2018 at 12:09:23PM +0100, Borislav Petkov escreveu:
> On Mon, Nov 12, 2018 at 03:40:51PM +0800, Pu Wen wrote:
> > The tool perf is useful for the performance analysis on the Hygon Dhyana
> > platform. But right now there is no Hygon support for it to analyze the
> > KVM guest os data. So add Hygon Dhyana support to it by checking vendor
>
> acme, pls fix that to "OS" when applying. Thx.
>
> > string to share the code path of AMD.
> >
> > Signed-off-by: Pu Wen <[email protected]>
> > ---
> > tools/perf/arch/x86/util/kvm-stat.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Acked-by: Borislav Petkov <[email protected]>

Thanks, applied.

- Arnaldo

> > diff --git a/tools/perf/arch/x86/util/kvm-stat.c b/tools/perf/arch/x86/util/kvm-stat.c
> > index b32409a..081353d 100644
> > --- a/tools/perf/arch/x86/util/kvm-stat.c
> > +++ b/tools/perf/arch/x86/util/kvm-stat.c
> > @@ -156,7 +156,7 @@ int cpu_isa_init(struct perf_kvm_stat *kvm, const char *cpuid)
> > if (strstr(cpuid, "Intel")) {
> > kvm->exit_reasons = vmx_exit_reasons;
> > kvm->exit_reasons_isa = "VMX";
> > - } else if (strstr(cpuid, "AMD")) {
> > + } else if (strstr(cpuid, "AMD") || strstr(cpuid, "Hygon")) {
> > kvm->exit_reasons = svm_exit_reasons;
> > kvm->exit_reasons_isa = "SVM";
> > } else
> > --
> > 2.7.4
> >
>
> --
> Regards/Gruss,
> Boris.
>
> Good mailing practices for 400: avoid top-posting and trim the reply.

2018-11-22 21:53:38

by tip-bot for Vasyl Gomonovych

Subject: [tip:perf/core] perf tools: Add Hygon Dhyana support

Commit-ID: 4787eff3fa88f62fede6ed7afa06477ae6bf984d
Gitweb: https://git.kernel.org/tip/4787eff3fa88f62fede6ed7afa06477ae6bf984d
Author: Pu Wen <[email protected]>
AuthorDate: Mon, 12 Nov 2018 15:40:51 +0800
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Wed, 21 Nov 2018 22:39:56 -0300

perf tools: Add Hygon Dhyana support

The tool perf is useful for the performance analysis on the Hygon Dhyana
platform. But right now there is no Hygon support for it to analyze the
KVM guest os data. So add Hygon Dhyana support to it by checking vendor
string to share the code path of AMD.

Signed-off-by: Pu Wen <[email protected]>
Acked-by: Borislav Petkov <[email protected]>
Cc: Alexander Shishkin <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/arch/x86/util/kvm-stat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/arch/x86/util/kvm-stat.c b/tools/perf/arch/x86/util/kvm-stat.c
index b32409a0e546..081353d7b095 100644
--- a/tools/perf/arch/x86/util/kvm-stat.c
+++ b/tools/perf/arch/x86/util/kvm-stat.c
@@ -156,7 +156,7 @@ int cpu_isa_init(struct perf_kvm_stat *kvm, const char *cpuid)
if (strstr(cpuid, "Intel")) {
kvm->exit_reasons = vmx_exit_reasons;
kvm->exit_reasons_isa = "VMX";
- } else if (strstr(cpuid, "AMD")) {
+ } else if (strstr(cpuid, "AMD") || strstr(cpuid, "Hygon")) {
kvm->exit_reasons = svm_exit_reasons;
kvm->exit_reasons_isa = "SVM";
} else