2018-11-15 12:26:25

by Yue Haibing

Subject: [PATCH -next] powerpc/platforms/85xx: drop pointless static qualifier

From: Yue Haibing <[email protected]>

There is no need to have the 'void __iomem *cpld_base' variable static
since new value always be assigned before use it.

Signed-off-by: Yue Haibing <[email protected]>
---
arch/powerpc/platforms/85xx/t1042rdb_diu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/85xx/t1042rdb_diu.c b/arch/powerpc/platforms/85xx/t1042rdb_diu.c
index dac36ba..2d16521 100644
--- a/arch/powerpc/platforms/85xx/t1042rdb_diu.c
+++ b/arch/powerpc/platforms/85xx/t1042rdb_diu.c
@@ -39,7 +39,7 @@
*/
static void t1042rdb_set_monitor_port(enum fsl_diu_monitor_port port)
{
- static void __iomem *cpld_base;
+ void __iomem *cpld_base;

cpld_base = of_iomap(cpld_node, 0);
if (!cpld_base) {

2018-11-27 09:23:32

by Michael Ellerman

Subject: Re: [-next] powerpc/platforms/85xx: drop pointless static qualifier

On Thu, 2018-11-15 at 12:33:16 UTC, YueHaibing wrote:
> From: Yue Haibing <[email protected]>
>
> There is no need to have the 'void __iomem *cpld_base' variable static
> since new value always be assigned before use it.
>
> Signed-off-by: Yue Haibing <[email protected]>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/af8511cf32189ba66c7e2a4146f11c

cheers