2018-11-30 08:07:48

by liujian (CE)

Subject: [PATCH 1/2] driver: scsi: ufs-qcom: fix returnvar.cocci warning

Remove unneeded variable used to store return value,
detected by the semantic patch returnvar.cocci.

Signed-off-by: liujian <[email protected]>
---
drivers/scsi/ufs/ufs-qcom.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
index 3aeadb1..4d5532d 100644
--- a/drivers/scsi/ufs/ufs-qcom.c
+++ b/drivers/scsi/ufs/ufs-qcom.c
@@ -543,7 +543,6 @@ static int ufs_qcom_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op)
{
struct ufs_qcom_host *host = ufshcd_get_variant(hba);
struct phy *phy = host->generic_phy;
- int ret = 0;

if (ufs_qcom_is_link_off(hba)) {
/*
@@ -569,7 +568,7 @@ static int ufs_qcom_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op)
}

out:
- return ret;
+ return 0;
}

static int ufs_qcom_resume(struct ufs_hba *hba, enum ufs_pm_op pm_op)
--
2.7.4

2018-11-30 08:07:50

by liujian (CE)

Subject: [PATCH 2/2] driver: scsi: qla2xxx: fix returnvar.cocci warning

Remove unneeded variable used to store return value,
detected by the semantic patch returnvar.cocci.

Signed-off-by: liujian <[email protected]>
---
drivers/scsi/qla2xxx/qla_mr.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_mr.c
index 60f964c..bb66ea4 100644
--- a/drivers/scsi/qla2xxx/qla_mr.c
+++ b/drivers/scsi/qla2xxx/qla_mr.c
@@ -1712,7 +1712,6 @@ qlafx00_tgt_detach(struct scsi_qla_host *vha, int tgt_id)
int
qlafx00_process_aen(struct scsi_qla_host *vha, struct qla_work_evt *evt)
{
- int rval = 0;
uint32_t aen_code, aen_data;

aen_code = FCH_EVT_VENDOR_UNIQUE;
@@ -1764,7 +1763,7 @@ qlafx00_process_aen(struct scsi_qla_host *vha, struct qla_work_evt *evt)
fc_host_post_event(vha->host, fc_get_event_number(),
aen_code, aen_data);

- return rval;
+ return 0;
}

static void
--
2.7.4