2018-12-18 07:35:47

by Doug Smythies

Subject: [PATCH] tools/power/x86/intel_pstate_tracer: Fix non root execution for post processing a trace file.

This script is supposed to be allowed to run with regular user privileges
if a previously captured trace is being post processed.

Commit fbe313884d7ddd73ce457473cbdf3763f5b1d3da
tools/power/x86/intel_pstate_tracer: Free the trace buffer memory
introduced a bug that breaks that option.

Commit 35459105deb26430653a7299a86bc66fb4dd5773
tools/power/x86/intel_pstate_tracer: Add optional setting of trace buffer memory allocation
moved the code but kept the bug.

This patch fixes the issue.

Signed-off-by: Doug Smythies <[email protected]>
---
tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
index 84e2b64..2fa3c57 100755
--- a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
+++ b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
@@ -585,9 +585,9 @@ current_max_cpu = 0

read_trace_data(filename)

-clear_trace_file()
-# Free the memory
if interval:
+ clear_trace_file()
+ # Free the memory
free_trace_buffer()

if graph_data_present == False:
--
2.7.4

2018-12-19 18:37:24

by srinivas pandruvada

Subject: Re: [PATCH] tools/power/x86/intel_pstate_tracer: Fix non root execution for post processing a trace file.

On Mon, 2018-12-17 at 23:34 -0800, Doug Smythies wrote:
> This script is supposed to be allowed to run with regular user
> privileges
> if a previously captured trace is being post processed.
>
> Commit fbe313884d7ddd73ce457473cbdf3763f5b1d3da
> tools/power/x86/intel_pstate_tracer: Free the trace buffer memory
> introduced a bug that breaks that option.
>
> Commit 35459105deb26430653a7299a86bc66fb4dd5773
> tools/power/x86/intel_pstate_tracer: Add optional setting of trace
> buffer memory allocation
> moved the code but kept the bug.
>
> This patch fixes the issue.
>
> Signed-off-by: Doug Smythies <[email protected]>
Acked-by: Srinivas Pandruvada <[email protected]>

> ---
> tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
> a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> index 84e2b64..2fa3c57 100755
> --- a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> +++ b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> @@ -585,9 +585,9 @@ current_max_cpu = 0
>
> read_trace_data(filename)
>
> -clear_trace_file()
> -# Free the memory
> if interval:
> + clear_trace_file()
> + # Free the memory
> free_trace_buffer()
>
> if graph_data_present == False:

2018-12-21 10:43:16

by Rafael J. Wysocki

Subject: Re: [PATCH] tools/power/x86/intel_pstate_tracer: Fix non root execution for post processing a trace file.

On Tuesday, December 18, 2018 8:34:04 AM CET Doug Smythies wrote:
> This script is supposed to be allowed to run with regular user privileges
> if a previously captured trace is being post processed.
>
> Commit fbe313884d7ddd73ce457473cbdf3763f5b1d3da
> tools/power/x86/intel_pstate_tracer: Free the trace buffer memory
> introduced a bug that breaks that option.
>
> Commit 35459105deb26430653a7299a86bc66fb4dd5773
> tools/power/x86/intel_pstate_tracer: Add optional setting of trace buffer memory allocation
> moved the code but kept the bug.
>
> This patch fixes the issue.
>
> Signed-off-by: Doug Smythies <[email protected]>
> ---
> tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> index 84e2b64..2fa3c57 100755
> --- a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> +++ b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> @@ -585,9 +585,9 @@ current_max_cpu = 0
>
> read_trace_data(filename)
>
> -clear_trace_file()
> -# Free the memory
> if interval:
> + clear_trace_file()
> + # Free the memory
> free_trace_buffer()
>
> if graph_data_present == False:
>

Applied, thanks!