2023-09-22 13:25:18

by Maciej Wieczor-Retman

Subject: [PATCH v3 8/8] selftests/resctrl: Fix wrong format specifier

A long unsigned int variable is passed to the ksft_print_msg() and the
format specifier used expects a variable of type int.

Change the format specifier to match the passed variable.

Reviewed-by: Ilpo Järvinen <[email protected]>
Signed-off-by: Maciej Wieczor-Retman <[email protected]>
---
Changelog v3:
- Add Reviewed-by tag. (Ilpo)

Changelog v2:
- Add this patch to the series.

tools/testing/selftests/resctrl/cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/resctrl/cache.c b/tools/testing/selftests/resctrl/cache.c
index d3cbb829ff6a..a5d082cd2d53 100644
--- a/tools/testing/selftests/resctrl/cache.c
+++ b/tools/testing/selftests/resctrl/cache.c
@@ -294,7 +294,7 @@ int show_cache_info(unsigned long sum_llc_val, int no_of_bits,
ret = platform && abs((int)diff_percent) > max_diff_percent &&
(cmt ? (abs(avg_diff) > max_diff) : true);

- ksft_print_msg("%s Check cache miss rate within %d%%\n",
+ ksft_print_msg("%s Check cache miss rate within %lu%%\n",
ret ? "Fail:" : "Pass:", max_diff_percent);

ksft_print_msg("Percent diff=%d\n", abs((int)diff_percent));
--
2.42.0

2023-09-30 08:16:27

by Reinette Chatre

Subject: Re: [PATCH v3 8/8] selftests/resctrl: Fix wrong format specifier

Hi Maciej,

On 9/22/2023 2:06 AM, Maciej Wieczor-Retman wrote:
> A long unsigned int variable is passed to the ksft_print_msg() and the
> format specifier used expects a variable of type int.
>
> Change the format specifier to match the passed variable.
>
> Reviewed-by: Ilpo Järvinen <[email protected]>
> Signed-off-by: Maciej Wieczor-Retman <[email protected]>
> ---

Thank you very much for this cleanup.

Reviewed-by: Reinette Chatre <[email protected]>

Reinette