2019-01-04 08:06:29

by Yue Haibing

Subject: [PATCH -next] xen/pvcalls: remove set but not used variable 'intf'

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/xen/pvcalls-back.c: In function 'pvcalls_sk_state_change':
drivers/xen/pvcalls-back.c:286:28: warning:
variable 'intf' set but not used [-Wunused-but-set-variable]

It not used since e6587cdbd732 ("pvcalls-back: set -ENOTCONN in
pvcalls_conn_back_read")

Signed-off-by: YueHaibing <[email protected]>
---
drivers/xen/pvcalls-back.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
index 71b6287..7aa64d1 100644
--- a/drivers/xen/pvcalls-back.c
+++ b/drivers/xen/pvcalls-back.c
@@ -283,12 +283,10 @@ static int pvcalls_back_socket(struct xenbus_device *dev,
static void pvcalls_sk_state_change(struct sock *sock)
{
struct sock_mapping *map = sock->sk_user_data;
- struct pvcalls_data_intf *intf;

if (map == NULL)
return;

- intf = map->ring;
atomic_inc(&map->read);
notify_remote_via_irq(map->irq);
}

2019-01-04 17:42:26

by Boris Ostrovsky

Subject: Re: [PATCH -next] xen/pvcalls: remove set but not used variable 'intf'

On 1/4/19 1:03 AM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/xen/pvcalls-back.c: In function 'pvcalls_sk_state_change':
> drivers/xen/pvcalls-back.c:286:28: warning:
> variable 'intf' set but not used [-Wunused-but-set-variable]
>
> It not used since e6587cdbd732 ("pvcalls-back: set -ENOTCONN in
> pvcalls_conn_back_read")
>
> Signed-off-by: YueHaibing <[email protected]>

Reviewed-by: Boris Ostrovsky <[email protected]>

and applied to for-linus-4.21.

Thanks.
-boris