2019-01-22 14:51:03

by wangbo

Subject: [PATCH v2] uio:remove unneeded variable ret

From: wangbo <[email protected]>

In uio_dmem_genirq_open the variable ret is unneeded,remove it now.

Signed-off-by: Bo Wang <[email protected]>
---
drivers/uio/uio_dmem_genirq.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/uio/uio_dmem_genirq.c b/drivers/uio/uio_dmem_genirq.c
index 003bada..2be7569 100644
--- a/drivers/uio/uio_dmem_genirq.c
+++ b/drivers/uio/uio_dmem_genirq.c
@@ -47,7 +47,6 @@ static int uio_dmem_genirq_open(struct uio_info *info, struct inode *inode)
{
struct uio_dmem_genirq_platdata *priv = info->priv;
struct uio_mem *uiomem;
- int ret = 0;
int dmem_region = priv->dmem_region_start;

uiomem = &priv->uioinfo->mem[priv->dmem_region_start];
@@ -71,7 +70,7 @@ static int uio_dmem_genirq_open(struct uio_info *info, struct inode *inode)
mutex_unlock(&priv->alloc_lock);
/* Wait until the Runtime PM code has woken up the device */
pm_runtime_get_sync(&priv->pdev->dev);
- return ret;
+ return 0;
}

static int uio_dmem_genirq_release(struct uio_info *info, struct inode *inode)
--
2.7.4

2019-02-12 09:18:55

by Greg Kroah-Hartman

Subject: Re: [PATCH v2] uio:remove unneeded variable ret

On Tue, Jan 22, 2019 at 10:33:57PM +0800, Bo Wang wrote:
> From: wangbo <[email protected]>
>
> In uio_dmem_genirq_open the variable ret is unneeded,remove it now.
>
> Signed-off-by: Bo Wang <[email protected]>

This name does not match up with the "From:" line :(

Please fix up and resend.

thanks

greg k-h