2019-01-24 07:11:52

by Zhangshaokun

[permalink] [raw]
Subject: [PATCH] iommu/dma: Remove unused variable

end_pfn is never used after commit <aa3ac9469c18> ('iommu/iova: Make dma
32bit pfn implicit'), cleanup it.

Cc: Joerg Roedel <[email protected]>
Cc: Robin Murphy <[email protected]>
Cc: Zhen Lei <[email protected]>
Signed-off-by: Shaokun Zhang <[email protected]>
---
drivers/iommu/dma-iommu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c
index d19f3d6b43c1..77aabe637a60 100644
--- a/drivers/iommu/dma-iommu.c
+++ b/drivers/iommu/dma-iommu.c
@@ -289,7 +289,7 @@ int iommu_dma_init_domain(struct iommu_domain *domain, dma_addr_t base,
{
struct iommu_dma_cookie *cookie = domain->iova_cookie;
struct iova_domain *iovad = &cookie->iovad;
- unsigned long order, base_pfn, end_pfn;
+ unsigned long order, base_pfn;
int attr;

if (!cookie || cookie->type != IOMMU_DMA_IOVA_COOKIE)
@@ -298,7 +298,6 @@ int iommu_dma_init_domain(struct iommu_domain *domain, dma_addr_t base,
/* Use the smallest supported page size for IOVA granularity */
order = __ffs(domain->pgsize_bitmap);
base_pfn = max_t(unsigned long, 1, base >> order);
- end_pfn = (base + size - 1) >> order;

/* Check the domain allows at least some access to the device... */
if (domain->geometry.force_aperture) {
--
2.7.4



2019-01-24 14:17:50

by Jörg Rödel

[permalink] [raw]
Subject: Re: [PATCH] iommu/dma: Remove unused variable

On Thu, Jan 24, 2019 at 03:10:02PM +0800, Shaokun Zhang wrote:
> drivers/iommu/dma-iommu.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Applied, thanks.