2019-01-29 08:33:01

by Yogesh Narayan Gaur

Subject: [PATCH] spi: spi-mem: spi-nxp-fspi: add module license info

Add MODULE_LICENSE info to fix below warning:
WARNING: modpost: missing MODULE_LICENSE() in drivers/spi/spi-nxp-fspi.o

Signed-off-by: Yogesh Narayan Gaur <[email protected]>
---
drivers/spi/spi-nxp-fspi.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c
index 0327216ef7aa..90f3d2e4fe5d 100644
--- a/drivers/spi/spi-nxp-fspi.c
+++ b/drivers/spi/spi-nxp-fspi.c
@@ -1103,3 +1103,4 @@ MODULE_AUTHOR("NXP Semiconductor");
MODULE_AUTHOR("Yogesh Narayan Gaur <[email protected]>");
MODULE_AUTHOR("Boris Brezillion <[email protected]>");
MODULE_AUTHOR("Frieder Schrempf <[email protected]>");
+MODULE_LICENSE("GPL v2");
--
2.17.1

2019-01-29 08:47:42

by Frieder Schrempf

Subject: Re: [PATCH] spi: spi-mem: spi-nxp-fspi: add module license info

On 29.01.19 09:31, Yogesh Narayan Gaur wrote:
> Add MODULE_LICENSE info to fix below warning:
> WARNING: modpost: missing MODULE_LICENSE() in drivers/spi/spi-nxp-fspi.o
>
> Signed-off-by: Yogesh Narayan Gaur <[email protected]>
> ---
> drivers/spi/spi-nxp-fspi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c
> index 0327216ef7aa..90f3d2e4fe5d 100644
> --- a/drivers/spi/spi-nxp-fspi.c
> +++ b/drivers/spi/spi-nxp-fspi.c
> @@ -1103,3 +1103,4 @@ MODULE_AUTHOR("NXP Semiconductor");
> MODULE_AUTHOR("Yogesh Narayan Gaur <[email protected]>");
> MODULE_AUTHOR("Boris Brezillion <[email protected]>");

I just found a typo in Boris' last name when I looked at this diff. The
second 'i' is too much.
The same typo can also be found in the comment header of the file.

> MODULE_AUTHOR("Frieder Schrempf <[email protected]>");
> +MODULE_LICENSE("GPL v2");
>

2019-01-29 09:42:15

by Boris Brezillon

Subject: Re: [PATCH] spi: spi-mem: spi-nxp-fspi: add module license info

On Tue, 29 Jan 2019 08:31:19 +0000
Yogesh Narayan Gaur <[email protected]> wrote:

> Add MODULE_LICENSE info to fix below warning:
> WARNING: modpost: missing MODULE_LICENSE() in drivers/spi/spi-nxp-fspi.o
>

You miss Fixes and Reported-by tags here.

> Signed-off-by: Yogesh Narayan Gaur <[email protected]>
> ---
> drivers/spi/spi-nxp-fspi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c
> index 0327216ef7aa..90f3d2e4fe5d 100644
> --- a/drivers/spi/spi-nxp-fspi.c
> +++ b/drivers/spi/spi-nxp-fspi.c
> @@ -1103,3 +1103,4 @@ MODULE_AUTHOR("NXP Semiconductor");
> MODULE_AUTHOR("Yogesh Narayan Gaur <[email protected]>");
> MODULE_AUTHOR("Boris Brezillion <[email protected]>");
> MODULE_AUTHOR("Frieder Schrempf <[email protected]>");
> +MODULE_LICENSE("GPL v2");