2008-11-24 20:05:42

by Hannes Eder

Subject: [PATCH] hugetlb: fix sparse warnings

Impact: fix sparse warnings

Fix the following sparse warnings:

mm/hugetlb.c:375:3: warning: returning void-valued expression
mm/hugetlb.c:408:3: warning: returning void-valued expression

Signed-off-by: Hannes Eder <[email protected]>
---
mm/hugetlb.c | 12 ++++++++----
1 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 6058b53..56e1406 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -371,8 +371,10 @@ static void clear_huge_page(struct page *page,
{
int i;

- if (unlikely(sz > MAX_ORDER_NR_PAGES))
- return clear_gigantic_page(page, addr, sz);
+ if (unlikely(sz > MAX_ORDER_NR_PAGES)) {
+ clear_gigantic_page(page, addr, sz);
+ return;
+ }

might_sleep();
for (i = 0; i < sz/PAGE_SIZE; i++) {
@@ -404,8 +406,10 @@ static void copy_huge_page(struct page *dst,
struct page *src,
int i;
struct hstate *h = hstate_vma(vma);

- if (unlikely(pages_per_huge_page(h) > MAX_ORDER_NR_PAGES))
- return copy_gigantic_page(dst, src, addr, vma);
+ if (unlikely(pages_per_huge_page(h) > MAX_ORDER_NR_PAGES)) {
+ copy_gigantic_page(dst, src, addr, vma);
+ return;
+ }

might_sleep();
for (i = 0; i < pages_per_huge_page(h); i++) {

2008-11-24 20:14:21

by Nishanth Aravamudan

Subject: Re: [PATCH] hugetlb: fix sparse warnings

On 24.11.2008 [21:05:31 +0100], Hannes Eder wrote:
> Impact: fix sparse warnings
>
> Fix the following sparse warnings:
>
> mm/hugetlb.c:375:3: warning: returning void-valued expression
> mm/hugetlb.c:408:3: warning: returning void-valued expression
>
> Signed-off-by: Hannes Eder <[email protected]>

Acked-by: Nishanth Aravamudan <[email protected]>

Thanks,
Nish