From: Jiada Wang <[email protected]>
commit 78bc93b3ffb2 ("arm64: dts: renesas: r8a7796: Add address
properties to rcar_sound port nodes") added missing #address-cells
and #size-cells for sound ports.
But, these are based on platform, not on SoC. This patch cleanups it.
Signed-off-by: Jiada Wang <[email protected]>
Signed-off-by: Timo Wischer <[email protected]>
---
arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 1 +
arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts | 1 +
arch/arm64/boot/dts/renesas/r8a7796.dtsi | 11 -----------
3 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
index b4f9567..2aefa53 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
@@ -68,6 +68,7 @@
ports {
/* rsnd_port0 is on salvator-common */
rsnd_port1: port@1 {
+ reg = <1>;
rsnd_endpoint1: endpoint {
remote-endpoint = <&dw_hdmi0_snd_in>;
diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts b/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts
index 8860be6..fa4ef7c 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts
@@ -69,6 +69,7 @@
ports {
/* rsnd_port0 is on salvator-common */
rsnd_port1: port@1 {
+ reg = <1>;
rsnd_endpoint1: endpoint {
remote-endpoint = <&dw_hdmi0_snd_in>;
diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index 0648d12..cc601d9 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -2162,17 +2162,6 @@
dma-names = "rx", "tx", "rxu", "txu";
};
};
-
- ports {
- #address-cells = <1>;
- #size-cells = <0>;
- port@0 {
- reg = <0>;
- };
- port@1 {
- reg = <1>;
- };
- };
};
audma0: dma-controller@ec700000 {
--
2.7.4
Hi
> From: Jiada Wang <[email protected]>
>
> commit 78bc93b3ffb2 ("arm64: dts: renesas: r8a7796: Add address
> properties to rcar_sound port nodes") added missing #address-cells
> and #size-cells for sound ports.
> But, these are based on platform, not on SoC. This patch cleanups it.
>
> Signed-off-by: Jiada Wang <[email protected]>
> Signed-off-by: Timo Wischer <[email protected]>
> ---
I thought I had mentioned about this, but it seems no fix...
Anyway
Acked-by: Kuninori Morimoto <[email protected]>
On Fri, Feb 22, 2019 at 10:34:59AM +0100, [email protected] wrote:
> From: Jiada Wang <[email protected]>
>
> commit 78bc93b3ffb2 ("arm64: dts: renesas: r8a7796: Add address
> properties to rcar_sound port nodes") added missing #address-cells
> and #size-cells for sound ports.
> But, these are based on platform, not on SoC. This patch cleanups it.
>
> Signed-off-by: Jiada Wang <[email protected]>
> Signed-off-by: Timo Wischer <[email protected]>
Thanks,
please CC patches for Renesas SoCs to [email protected] (CCed)
so they appear in my patch queue.
Otherwise, this patch looks fine to me but I will wait to see if there are
other reviews before applying.
Reviewed-by: Simon Horman <[email protected]>
> ---
> arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 1 +
> arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts | 1 +
> arch/arm64/boot/dts/renesas/r8a7796.dtsi | 11 -----------
> 3 files changed, 2 insertions(+), 11 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> index b4f9567..2aefa53 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> @@ -68,6 +68,7 @@
> ports {
> /* rsnd_port0 is on salvator-common */
> rsnd_port1: port@1 {
> + reg = <1>;
> rsnd_endpoint1: endpoint {
> remote-endpoint = <&dw_hdmi0_snd_in>;
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts b/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts
> index 8860be6..fa4ef7c 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts
> @@ -69,6 +69,7 @@
> ports {
> /* rsnd_port0 is on salvator-common */
> rsnd_port1: port@1 {
> + reg = <1>;
> rsnd_endpoint1: endpoint {
> remote-endpoint = <&dw_hdmi0_snd_in>;
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> index 0648d12..cc601d9 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> @@ -2162,17 +2162,6 @@
> dma-names = "rx", "tx", "rxu", "txu";
> };
> };
> -
> - ports {
> - #address-cells = <1>;
> - #size-cells = <0>;
> - port@0 {
> - reg = <0>;
> - };
> - port@1 {
> - reg = <1>;
> - };
> - };
> };
>
> audma0: dma-controller@ec700000 {
> --
> 2.7.4
>
On Mon, Feb 25, 2019 at 10:30:49AM +0900, Kuninori Morimoto wrote:
>
> Hi
>
> > From: Jiada Wang <[email protected]>
> >
> > commit 78bc93b3ffb2 ("arm64: dts: renesas: r8a7796: Add address
> > properties to rcar_sound port nodes") added missing #address-cells
> > and #size-cells for sound ports.
> > But, these are based on platform, not on SoC. This patch cleanups it.
> >
> > Signed-off-by: Jiada Wang <[email protected]>
> > Signed-off-by: Timo Wischer <[email protected]>
> > ---
>
> I thought I had mentioned about this, but it seems no fix...
> Anyway
>
> Acked-by: Kuninori Morimoto <[email protected]>
Thanks Morimoto-san,
applied for v5.2.
[CC [email protected], for the record]
On Mon, Feb 25, 2019 at 10:00:54AM +0100, Simon Horman wrote:
> On Mon, Feb 25, 2019 at 10:30:49AM +0900, Kuninori Morimoto wrote:
> >
> > Hi
> >
> > > From: Jiada Wang <[email protected]>
> > >
> > > commit 78bc93b3ffb2 ("arm64: dts: renesas: r8a7796: Add address
> > > properties to rcar_sound port nodes") added missing #address-cells
> > > and #size-cells for sound ports.
> > > But, these are based on platform, not on SoC. This patch cleanups it.
> > >
> > > Signed-off-by: Jiada Wang <[email protected]>
> > > Signed-off-by: Timo Wischer <[email protected]>
> > > ---
> >
> > I thought I had mentioned about this, but it seems no fix...
> > Anyway
> >
> > Acked-by: Kuninori Morimoto <[email protected]>
>
> Thanks Morimoto-san,
>
> applied for v5.2.