2019-02-23 03:19:08

by Anson Huang

Subject: [PATCH] gpio: mxc: add check to return defer probe if clock tree NOT ready

On i.MX8MQ platform, clock driver uses platform driver
model and it is probed after GPIO driver, so when GPIO
driver fails to get clock, it should check the error type
to decide whether to return defer probe or just ignore
the clock operation.

Fixes: 2808801aab8a ("gpio: mxc: add clock operation")
Signed-off-by: Anson Huang <[email protected]>
---
drivers/gpio/gpio-mxc.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
index 2d1dfa1..e86e61d 100644
--- a/drivers/gpio/gpio-mxc.c
+++ b/drivers/gpio/gpio-mxc.c
@@ -438,8 +438,11 @@ static int mxc_gpio_probe(struct platform_device *pdev)

/* the controller clock is optional */
port->clk = devm_clk_get(&pdev->dev, NULL);
- if (IS_ERR(port->clk))
+ if (IS_ERR(port->clk)) {
+ if (PTR_ERR(port->clk) == -EPROBE_DEFER)
+ return -EPROBE_DEFER;
port->clk = NULL;
+ }

err = clk_prepare_enable(port->clk);
if (err) {
--
2.7.4

2019-02-25 12:44:22

by Linus Walleij

Subject: Re: [PATCH] gpio: mxc: add check to return defer probe if clock tree NOT ready

On Sat, Feb 23, 2019 at 4:18 AM Anson Huang <[email protected]> wrote:

> On i.MX8MQ platform, clock driver uses platform driver
> model and it is probed after GPIO driver, so when GPIO
> driver fails to get clock, it should check the error type
> to decide whether to return defer probe or just ignore
> the clock operation.
>
> Fixes: 2808801aab8a ("gpio: mxc: add clock operation")
> Signed-off-by: Anson Huang <[email protected]>

Patch applied.

Yours,
Linus Walleij