2006-12-07 11:34:29

by Adrian Bunk

Subject: [2.6 patch] drivers/net/bnx2.c: add an error check

This patch adds a missing error check spotted by the Coverity checker.

Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.19-rc6-mm2/drivers/net/bnx2.c.old 2006-12-06 13:32:51.000000000 +0100
+++ linux-2.6.19-rc6-mm2/drivers/net/bnx2.c 2006-12-06 13:33:34.000000000 +0100
@@ -2510,7 +2510,7 @@
if (CHIP_NUM(bp) == CHIP_NUM_5709) {
fw = &bnx2_cp_fw_09;

- load_cpu_fw(bp, &cpu_reg, fw);
+ rc = load_cpu_fw(bp, &cpu_reg, fw);
if (rc)
goto init_cpu_err;
}

2006-12-07 11:48:03

by Jeff Garzik

Subject: Re: [2.6 patch] drivers/net/bnx2.c: add an error check

Adrian Bunk wrote:
> This patch adds a missing error check spotted by the Coverity checker.
>
> Signed-off-by: Adrian Bunk <[email protected]>

ACK

2006-12-07 17:31:57

by Michael Chan

Subject: Re: [2.6 patch] drivers/net/bnx2.c: add an error check

Adrian Bunk wrote:
> This patch adds a missing error check spotted by the Coverity checker.
>
> Signed-off-by: Adrian Bunk <[email protected]>
>
Acked-by: Michael Chan <[email protected]>

2006-12-07 23:10:25

by David Miller

Subject: Re: [2.6 patch] drivers/net/bnx2.c: add an error check

From: "Michael Chan" <[email protected]>
Date: Thu, 7 Dec 2006 09:31:40 -0800

>
> Adrian Bunk wrote:
> > This patch adds a missing error check spotted by the Coverity checker.
> >
> > Signed-off-by: Adrian Bunk <[email protected]>
> >
> Acked-by: Michael Chan <[email protected]>

Applied, thanks everyone.