2019-03-14 23:27:04

by Colin King

Subject: [PATCH] iio: adc: fix indentation issue, remove extra tab

From: Colin Ian King <[email protected]>

A return statement is indented one level too deeply; clean this
up by removing a tab.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/iio/adc/ad7124.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c
index 7d5e5311d8de..659ef37d5fe8 100644
--- a/drivers/iio/adc/ad7124.c
+++ b/drivers/iio/adc/ad7124.c
@@ -411,7 +411,7 @@ static int ad7124_init_channel_vref(struct ad7124_state *st,
dev_err(&st->sd.spi->dev,
"Error, trying to use external voltage reference without a %s regulator.\n",
ad7124_ref_names[refsel]);
- return PTR_ERR(st->vref[refsel]);
+ return PTR_ERR(st->vref[refsel]);
}
st->channel_config[channel_number].vref_mv =
regulator_get_voltage(st->vref[refsel]);
--
2.20.1

2019-03-15 09:28:15

by Popa, Stefan Serban

Subject: Re: [PATCH] iio: adc: fix indentation issue, remove extra tab

On Jo, 2019-03-14 at 23:26 +0000, Colin King wrote:
> [External]
>
>
> From: Colin Ian King <[email protected]>
>
> A return statement is indented one level too deeply; clean this
> up by removing a tab.
>
> Signed-off-by: Colin Ian King <[email protected]>
Acked-by: Stefan Popa <[email protected]>

Thanks!

> ---
>  drivers/iio/adc/ad7124.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c
> index 7d5e5311d8de..659ef37d5fe8 100644
> --- a/drivers/iio/adc/ad7124.c
> +++ b/drivers/iio/adc/ad7124.c
> @@ -411,7 +411,7 @@ static int ad7124_init_channel_vref(struct
> ad7124_state *st,
>                         dev_err(&st->sd.spi->dev,
>                                 "Error, trying to use external voltage
> reference without a %s regulator.\n",
>                                 ad7124_ref_names[refsel]);
> -                               return PTR_ERR(st->vref[refsel]);
> +                       return PTR_ERR(st->vref[refsel]);
>                 }
>                 st->channel_config[channel_number].vref_mv =
>                         regulator_get_voltage(st->vref[refsel]);
> --
> 2.20.1
>

2019-03-16 16:39:00

by Jonathan Cameron

Subject: Re: [PATCH] iio: adc: fix indentation issue, remove extra tab

On Fri, 15 Mar 2019 09:25:38 +0000
"Popa, Stefan Serban" <[email protected]> wrote:

> On Jo, 2019-03-14 at 23:26 +0000, Colin King wrote:
> > [External]
> >
> >
> > From: Colin Ian King <[email protected]>
> >
> > A return statement is indented one level too deeply; clean this
> > up by removing a tab.
> >
> > Signed-off-by: Colin Ian King <[email protected]>
> Acked-by: Stefan Popa <[email protected]>
>
Applied thanks.

Jonathan

> Thanks!
>
> > ---
> >  drivers/iio/adc/ad7124.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c
> > index 7d5e5311d8de..659ef37d5fe8 100644
> > --- a/drivers/iio/adc/ad7124.c
> > +++ b/drivers/iio/adc/ad7124.c
> > @@ -411,7 +411,7 @@ static int ad7124_init_channel_vref(struct
> > ad7124_state *st,
> >                         dev_err(&st->sd.spi->dev,
> >                                 "Error, trying to use external voltage
> > reference without a %s regulator.\n",
> >                                 ad7124_ref_names[refsel]);
> > -                               return PTR_ERR(st->vref[refsel]);
> > +                       return PTR_ERR(st->vref[refsel]);
> >                 }
> >                 st->channel_config[channel_number].vref_mv =
> >                         regulator_get_voltage(st->vref[refsel]);
> > --
> > 2.20.1
> >