2019-03-21 09:11:33

by Li RongQing

Subject: [PATCH] mm, slab: remove unneed check in cpuup_canceled

nc is a member of percpu allocation memory, and impossible NULL

Signed-off-by: Li RongQing <[email protected]>
---
mm/slab.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/mm/slab.c b/mm/slab.c
index 28652e4218e0..f1420e14875a 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -990,10 +990,8 @@ static void cpuup_canceled(long cpu)

/* cpu is dead; no one can alloc from it. */
nc = per_cpu_ptr(cachep->cpu_cache, cpu);
- if (nc) {
- free_block(cachep, nc->entry, nc->avail, node, &list);
- nc->avail = 0;
- }
+ free_block(cachep, nc->entry, nc->avail, node, &list);
+ nc->avail = 0;

if (!cpumask_empty(mask)) {
spin_unlock_irq(&n->list_lock);
--
2.16.2

2019-03-22 17:40:14

by Christoph Lameter (Ampere)

Subject: Re: [PATCH] mm, slab: remove unneed check in cpuup_canceled

On Thu, 21 Mar 2019, Li RongQing wrote:

> nc is a member of percpu allocation memory, and impossible NULL

Acked-by: Christoph Lameter <[email protected]>