2019-03-27 07:51:28

by Mukesh Ojha

[permalink] [raw]
Subject: [PATCH] Yama: mark function as static

Sparse complains yama_task_prctl can be static. Fix it by making
it static.

Signed-off-by: Mukesh Ojha <[email protected]>
---
security/yama/yama_lsm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/yama/yama_lsm.c b/security/yama/yama_lsm.c
index 57cc607..9c5a15b 100644
--- a/security/yama/yama_lsm.c
+++ b/security/yama/yama_lsm.c
@@ -222,7 +222,7 @@ void yama_task_free(struct task_struct *task)
* Return 0 on success, -ve on error. -ENOSYS is returned when Yama
* does not handle the given option.
*/
-int yama_task_prctl(int option, unsigned long arg2, unsigned long arg3,
+static int yama_task_prctl(int option, unsigned long arg2, unsigned long arg3,
unsigned long arg4, unsigned long arg5)
{
int rc = -ENOSYS;
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center,
Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project



2019-04-10 19:05:49

by James Morris

[permalink] [raw]
Subject: Re: [PATCH] Yama: mark function as static

On Wed, 27 Mar 2019, Mukesh Ojha wrote:

> Sparse complains yama_task_prctl can be static. Fix it by making
> it static.
>
> Signed-off-by: Mukesh Ojha <[email protected]>

Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-general

--
James Morris
<[email protected]>