2019-04-03 09:48:32

by Nicholas Mc Guire

[permalink] [raw]
Subject: [PATCH 1/2] staging:iio:accel:adis16203: add SPDX license identifier tag

Pop in the SPDX tag as the license is clearly indicated
as GPL V2 or later this should also be indicated with a SPDX license
identifier tag.

Signed-off-by: Nicholas Mc Guire <[email protected]>
---

chackpatch.pl was warning:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

Patch was compile tested with: X86_64_defconfig + SPI=y, IIO=m
STAGING=y, ADIS16203=m

Patch is against 5.1-rc3 (localversion-next is next-20190403)

drivers/staging/iio/accel/adis16203.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/staging/iio/accel/adis16203.c b/drivers/staging/iio/accel/adis16203.c
index 5cc96c80..cf9d41a 100644
--- a/drivers/staging/iio/accel/adis16203.c
+++ b/drivers/staging/iio/accel/adis16203.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
/*
* ADIS16203 Programmable 360 Degrees Inclinometer
*
--
2.1.4


2019-04-03 09:48:14

by Nicholas Mc Guire

[permalink] [raw]
Subject: [PATCH 2/2] staging:iio:accel:adis16240: add SPDX license identifier tag

Pop in the SPDX tag as the license is clearly indicated
as GPL V2 or later this should also be indicated with a SPDX license
identifier tag.

Signed-off-by: Nicholas Mc Guire <[email protected]>
---

chackpatch.pl was warning:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

Patch was compile tested with: x86_64_defconfig + SPI=y, IIO=m
STAGING=y, ADIS16240=m

Patch is against 5.1-rc3 (localversion-next is next-20190403)

drivers/staging/iio/accel/adis16240.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c
index 24e525f..b2d71ae 100644
--- a/drivers/staging/iio/accel/adis16240.c
+++ b/drivers/staging/iio/accel/adis16240.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
/*
* ADIS16240 Programmable Impact Sensor and Recorder driver
*
--
2.1.4

2019-04-03 12:40:23

by Himanshu Jha

[permalink] [raw]
Subject: Re: [PATCH 1/2] staging:iio:accel:adis16203: add SPDX license identifier tag

On Wed, Apr 03, 2019 at 11:41:28AM +0200, Nicholas Mc Guire wrote:
> Pop in the SPDX tag as the license is clearly indicated
> as GPL V2 or later this should also be indicated with a SPDX license
> identifier tag.
>
> Signed-off-by: Nicholas Mc Guire <[email protected]>
> ---
>
> chackpatch.pl was warning:
> WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
>
> Patch was compile tested with: X86_64_defconfig + SPI=y, IIO=m
> STAGING=y, ADIS16203=m
>
> Patch is against 5.1-rc3 (localversion-next is next-20190403)
>
> drivers/staging/iio/accel/adis16203.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/iio/accel/adis16203.c b/drivers/staging/iio/accel/adis16203.c
> index 5cc96c80..cf9d41a 100644
> --- a/drivers/staging/iio/accel/adis16203.c
> +++ b/drivers/staging/iio/accel/adis16203.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later

SPDX-License-Identifier: GPL-2.0+ ?

Documentation/process/license-rules.rst

For 'GNU General Public License (GPL) version 2 or any later version' use:
SPDX-License-Identifier: GPL-2.0+

The following should also be removed in this same patch:

* Licensed under the GPL-2 or later.

And lastly, MODULE_LICENSE() should also be checked, which appear
to be correct in its current form.

> /*
> * ADIS16203 Programmable 360 Degrees Inclinometer
> *
> --
> 2.1.4
>

--
Himanshu Jha
Undergraduate Student
Department of Electronics & Communication
Guru Tegh Bahadur Institute of Technology

2019-04-03 13:32:28

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 1/2] staging:iio:accel:adis16203: add SPDX license identifier tag

On Wed, Apr 03, 2019 at 11:41:28AM +0200, Nicholas Mc Guire wrote:
> Pop in the SPDX tag as the license is clearly indicated
> as GPL V2 or later this should also be indicated with a SPDX license
> identifier tag.
>
> Signed-off-by: Nicholas Mc Guire <[email protected]>

I sent patches yesterday to fix up all of drivers/staging/ for all spdx
issues so as to keep people from accidentally getting this wrong. That
patch is now in my tree and will show up in linux-next tomorrow.

Sorry,

greg k-h