2019-04-04 13:17:21

by Sandeep Singh

Subject: [PATCH] pinctrl: Added IRQF_SHARED flag for amd-pinctrl driver

From: Sandeep Singh <[email protected]>

Some of the AMD reference boards used single GPIO line for
multiple devices. So added IRQF_SHARED flag in amd pinctrl driver.


Signed-off-by: Sandeep Singh <[email protected]>
Signed-off-by: Shyam Sundar S K <[email protected]>
cc: Nehal Shah <[email protected]>
---
drivers/pinctrl/pinctrl-amd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c
index 2a7d638..d834c1e 100644
--- a/drivers/pinctrl/pinctrl-amd.c
+++ b/drivers/pinctrl/pinctrl-amd.c
@@ -930,8 +930,8 @@ static int amd_gpio_probe(struct platform_device *pdev)
goto out2;
}

- ret = devm_request_irq(&pdev->dev, irq_base, amd_gpio_irq_handler, 0,
- KBUILD_MODNAME, gpio_dev);
+ ret = devm_request_irq(&pdev->dev, irq_base, amd_gpio_irq_handler,
+ IRQF_SHARED, KBUILD_MODNAME, gpio_dev);
if (ret)
goto out2;

--
2.7.4

2019-04-08 12:47:13

by Linus Walleij

Subject: Re: [PATCH] pinctrl: Added IRQF_SHARED flag for amd-pinctrl driver

On Thu, Apr 4, 2019 at 3:16 PM Singh, Sandeep <[email protected]> wrote:

> From: Sandeep Singh <[email protected]>
>
> Some of the AMD reference boards used single GPIO line for
> multiple devices. So added IRQF_SHARED flag in amd pinctrl driver.
>
>
> Signed-off-by: Sandeep Singh <[email protected]>
> Signed-off-by: Shyam Sundar S K <[email protected]>
> cc: Nehal Shah <[email protected]>

OK makes perfect sense so patch applied.

The patch itself looked funny when I tried to apply it but
as it's just a oneliner I managed to fix it up.

Yours,
Linus Walleij