2019-04-14 18:42:51

by Mohan Kumar

Subject: [PATCH] [PATCHv1] drivers: edac: This patch fix the following checkpatch warning.

Use pr_warn instead of printk

WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ...
then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...

Signed-off-by: Mohan Kumar <[email protected]>
---
drivers/edac/x38_edac.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/edac/x38_edac.c b/drivers/edac/x38_edac.c
index cc779f3..4c855c0 100644
--- a/drivers/edac/x38_edac.c
+++ b/drivers/edac/x38_edac.c
@@ -14,6 +14,7 @@
#include <linux/pci.h>
#include <linux/pci_ids.h>
#include <linux/edac.h>
+#include <linux/netdevice.h>

#include <linux/io-64-nonatomic-lo-hi.h>
#include "edac_module.h"
@@ -260,7 +261,7 @@ static void __iomem *x38_map_mchbar(struct pci_dev *pdev)
u.mchbar &= X38_MCHBAR_MASK;

if (u.mchbar != (resource_size_t)u.mchbar) {
- printk(KERN_ERR
+ pr_err(
"x38: mmio space beyond accessible range (0x%llx)\n",
(unsigned long long)u.mchbar);
return NULL;
@@ -268,7 +269,7 @@ static void __iomem *x38_map_mchbar(struct pci_dev *pdev)

window = ioremap_nocache(u.mchbar, X38_MMR_WINDOW_SIZE);
if (!window)
- printk(KERN_ERR "x38: cannot map mmio space at 0x%llx\n",
+ pr_err("x38: cannot map mmio space at 0x%llx\n",
(unsigned long long)u.mchbar);

return window;
--
2.7.4

2019-04-14 18:52:41

by Borislav Petkov

Subject: Re: [PATCH] [PATCHv1] drivers: edac: This patch fix the following checkpatch warning.

On Sun, Apr 14, 2019 at 09:41:50PM +0300, Mohan Kumar wrote:
> Use pr_warn instead of printk
>
> WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ...
> then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...

Please read this here first on what to put in your patch title and commit
message:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html

> Signed-off-by: Mohan Kumar <[email protected]>
> ---
> drivers/edac/x38_edac.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/edac/x38_edac.c b/drivers/edac/x38_edac.c
> index cc779f3..4c855c0 100644
> --- a/drivers/edac/x38_edac.c
> +++ b/drivers/edac/x38_edac.c
> @@ -14,6 +14,7 @@
> #include <linux/pci.h>
> #include <linux/pci_ids.h>
> #include <linux/edac.h>
> +#include <linux/netdevice.h>
>
> #include <linux/io-64-nonatomic-lo-hi.h>
> #include "edac_module.h"
> @@ -260,7 +261,7 @@ static void __iomem *x38_map_mchbar(struct pci_dev *pdev)
> u.mchbar &= X38_MCHBAR_MASK;
>
> if (u.mchbar != (resource_size_t)u.mchbar) {
> - printk(KERN_ERR
> + pr_err(
> "x38: mmio space beyond accessible range (0x%llx)\n",

Put those two on a single line so that you don't have an ugly linebreak
like that.

Thx.

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

2019-04-14 20:20:50

by Borislav Petkov

Subject: Re: [PATCH] [PATCHv1] drivers: edac: This patch fix the following checkpatch warning.

On Sun, Apr 14, 2019 at 10:09:49PM +0300, mohan kumar wrote:
> Ok Thanks, I will do that.

Good.

One more thing: please do not top-post when replying on public mailing
lists.

Thx.

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.