2019-04-22 19:21:42

by Daniel G

Subject: [PATCH] spi: TI power management: add missing of table registration

MODULE_DEVICE_TABLE(of, <of_match_table> should be called to complete DT
OF mathing mechanism and register it.

Before this patch:
modinfo drivers/mfd/tps65912-spi.ko | grep alias
alias: spi:tps65912

After this patch:
modinfo drivers/mfd/tps65912-spi.ko | grep alias
alias: of:N*T*Cti,tps65912C*
alias: of:N*T*Cti,tps65912
alias: spi:tps65912

Reported-by: Javier Martinez Canillas <[email protected]>
Signed-off-by: Daniel Gomez <[email protected]>
---
drivers/mfd/tps65912-spi.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/tps65912-spi.c b/drivers/mfd/tps65912-spi.c
index 3bd7506..f78be03 100644
--- a/drivers/mfd/tps65912-spi.c
+++ b/drivers/mfd/tps65912-spi.c
@@ -27,6 +27,7 @@ static const struct of_device_id tps65912_spi_of_match_table[] = {
{ .compatible = "ti,tps65912", },
{ /* sentinel */ }
};
+MODULE_DEVICE_TABLE(of, tps65912_spi_of_match_table);

static int tps65912_spi_probe(struct spi_device *spi)
{
--
2.7.4

2019-05-08 10:28:48

by Lee Jones

Subject: Re: [PATCH] spi: TI power management: add missing of table registration

The subject line is not correct. This is an MFD driver.

When submitting you should follow the convention for the subsystem you
are patching against. The following command is helpful:

`git log --oneline -- <SUBSYSTEM>`

I will fix it for you this time (and for the other patch I see).

On Mon, 22 Apr 2019, Daniel Gomez wrote:

> MODULE_DEVICE_TABLE(of, <of_match_table> should be called to complete DT
> OF mathing mechanism and register it.
>
> Before this patch:
> modinfo drivers/mfd/tps65912-spi.ko | grep alias
> alias: spi:tps65912
>
> After this patch:
> modinfo drivers/mfd/tps65912-spi.ko | grep alias
> alias: of:N*T*Cti,tps65912C*
> alias: of:N*T*Cti,tps65912
> alias: spi:tps65912
>
> Reported-by: Javier Martinez Canillas <[email protected]>
> Signed-off-by: Daniel Gomez <[email protected]>
> ---
> drivers/mfd/tps65912-spi.c | 1 +
> 1 file changed, 1 insertion(+)

Applied, thanks.

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

2019-05-11 08:32:51

by Daniel G

Subject: Re: [PATCH] spi: TI power management: add missing of table registration

On Wed, May 8, 2019 at 12:27 PM Lee Jones <[email protected]> wrote:
>
> The subject line is not correct. This is an MFD driver.
>
> When submitting you should follow the convention for the subsystem you
> are patching against. The following command is helpful:
>
> `git log --oneline -- <SUBSYSTEM>`
>
> I will fix it for you this time (and for the other patch I see).
>
Sorry for that and thanks for rewriting the subject.

> On Mon, 22 Apr 2019, Daniel Gomez wrote:
>
> > MODULE_DEVICE_TABLE(of, <of_match_table> should be called to complete DT
> > OF mathing mechanism and register it.
> >
> > Before this patch:
> > modinfo drivers/mfd/tps65912-spi.ko | grep alias
> > alias: spi:tps65912
> >
> > After this patch:
> > modinfo drivers/mfd/tps65912-spi.ko | grep alias
> > alias: of:N*T*Cti,tps65912C*
> > alias: of:N*T*Cti,tps65912
> > alias: spi:tps65912
> >
> > Reported-by: Javier Martinez Canillas <[email protected]>
> > Signed-off-by: Daniel Gomez <[email protected]>
> > ---
> > drivers/mfd/tps65912-spi.c | 1 +
> > 1 file changed, 1 insertion(+)
>
> Applied, thanks.
>
> --
> Lee Jones [李琼斯]
> Linaro Services Technical Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog