2019-04-26 06:56:26

by Vabhav Sharma

[permalink] [raw]
Subject: [PATCH v4] clk: qoriq: add support for lx2160a

Add clockgen support and configuration for NXP SoC lx2160a
with compatible property as "fsl,lx2160a-clockgen".

Signed-off-by: Tang Yuantian <[email protected]>
Signed-off-by: Yogesh Gaur <[email protected]>
Signed-off-by: Vabhav Sharma <[email protected]>
Acked-by: Scott Wood <[email protected]>
Acked-by: Stephen Boyd <[email protected]>
Acked-by: Viresh Kumar <[email protected]>
---
Changes for v4:
- Incorporated review comments from Stephen Boyd

Changes for v3:
- Incorporated review comments of Rafael J. Wysocki
- Updated commit message

Changes for v2:
- Subject line updated

drivers/clk/clk-qoriq.c | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c
index 3d51d7c..1a15201 100644
--- a/drivers/clk/clk-qoriq.c
+++ b/drivers/clk/clk-qoriq.c
@@ -570,6 +570,17 @@ static const struct clockgen_chipinfo chipinfo[] = {
.flags = CG_VER3 | CG_LITTLE_ENDIAN,
},
{
+ .compat = "fsl,lx2160a-clockgen",
+ .cmux_groups = {
+ &clockgen2_cmux_cga12, &clockgen2_cmux_cgb
+ },
+ .cmux_to_group = {
+ 0, 0, 0, 0, 1, 1, 1, 1, -1
+ },
+ .pll_mask = 0x37,
+ .flags = CG_VER3 | CG_LITTLE_ENDIAN,
+ },
+ {
.compat = "fsl,p2041-clockgen",
.guts_compat = "fsl,qoriq-device-config-1.0",
.init_periph = p2041_init_periph,
@@ -1427,6 +1438,7 @@ CLK_OF_DECLARE(qoriq_clockgen_ls1043a, "fsl,ls1043a-clockgen", clockgen_init);
CLK_OF_DECLARE(qoriq_clockgen_ls1046a, "fsl,ls1046a-clockgen", clockgen_init);
CLK_OF_DECLARE(qoriq_clockgen_ls1088a, "fsl,ls1088a-clockgen", clockgen_init);
CLK_OF_DECLARE(qoriq_clockgen_ls2080a, "fsl,ls2080a-clockgen", clockgen_init);
+CLK_OF_DECLARE(qoriq_clockgen_lx2160a, "fsl,lx2160a-clockgen", clockgen_init);
CLK_OF_DECLARE(qoriq_clockgen_p2041, "fsl,p2041-clockgen", clockgen_init);
CLK_OF_DECLARE(qoriq_clockgen_p3041, "fsl,p3041-clockgen", clockgen_init);
CLK_OF_DECLARE(qoriq_clockgen_p4080, "fsl,p4080-clockgen", clockgen_init);
--
2.7.4


2019-05-21 05:45:16

by Vabhav Sharma

[permalink] [raw]
Subject: RE: [PATCH v4] clk: qoriq: add support for lx2160a

Hello Stephen,
I have incorporated review comments from https://patchwork.kernel.org/patch/10917171/

A gentle reminder to apply the patch https://patchwork.kernel.org/patch/10918407/.

Regards,
Vabhav

> -----Original Message-----
> From: Vabhav Sharma <[email protected]>
> Sent: Friday, April 26, 2019 12:24 PM
> To: [email protected]; [email protected]
> Cc: [email protected]; [email protected]; Vabhav Sharma
> <[email protected]>; Andy Tang <[email protected]>; Yogesh
> Narayan Gaur <[email protected]>
> Subject: [PATCH v4] clk: qoriq: add support for lx2160a
>
> Add clockgen support and configuration for NXP SoC lx2160a with
> compatible property as "fsl,lx2160a-clockgen".
>
> Signed-off-by: Tang Yuantian <[email protected]>
> Signed-off-by: Yogesh Gaur <[email protected]>
> Signed-off-by: Vabhav Sharma <[email protected]>
> Acked-by: Scott Wood <[email protected]>
> Acked-by: Stephen Boyd <[email protected]>
> Acked-by: Viresh Kumar <[email protected]>
> ---
> Changes for v4:
> - Incorporated review comments from Stephen Boyd
>
> Changes for v3:
> - Incorporated review comments of Rafael J. Wysocki
> - Updated commit message
>
> Changes for v2:
> - Subject line updated
>
> drivers/clk/clk-qoriq.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c index
> 3d51d7c..1a15201 100644
> --- a/drivers/clk/clk-qoriq.c
> +++ b/drivers/clk/clk-qoriq.c
> @@ -570,6 +570,17 @@ static const struct clockgen_chipinfo chipinfo[] = {
> .flags = CG_VER3 | CG_LITTLE_ENDIAN,
> },
> {
> + .compat = "fsl,lx2160a-clockgen",
> + .cmux_groups = {
> + &clockgen2_cmux_cga12, &clockgen2_cmux_cgb
> + },
> + .cmux_to_group = {
> + 0, 0, 0, 0, 1, 1, 1, 1, -1
> + },
> + .pll_mask = 0x37,
> + .flags = CG_VER3 | CG_LITTLE_ENDIAN,
> + },
> + {
> .compat = "fsl,p2041-clockgen",
> .guts_compat = "fsl,qoriq-device-config-1.0",
> .init_periph = p2041_init_periph,
> @@ -1427,6 +1438,7 @@ CLK_OF_DECLARE(qoriq_clockgen_ls1043a,
> "fsl,ls1043a-clockgen", clockgen_init);
> CLK_OF_DECLARE(qoriq_clockgen_ls1046a, "fsl,ls1046a-clockgen",
> clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_ls1088a, "fsl,ls1088a-
> clockgen", clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_ls2080a,
> "fsl,ls2080a-clockgen", clockgen_init);
> +CLK_OF_DECLARE(qoriq_clockgen_lx2160a, "fsl,lx2160a-clockgen",
> +clockgen_init);
> CLK_OF_DECLARE(qoriq_clockgen_p2041, "fsl,p2041-clockgen", clockgen_init);
> CLK_OF_DECLARE(qoriq_clockgen_p3041, "fsl,p3041-clockgen", clockgen_init);
> CLK_OF_DECLARE(qoriq_clockgen_p4080, "fsl,p4080-clockgen", clockgen_init);
> --
> 2.7.4

2019-05-23 14:08:52

by Vabhav Sharma

[permalink] [raw]
Subject: RE: [PATCH v4] clk: qoriq: add support for lx2160a

> -----Original Message-----
> From: Vabhav Sharma
> Sent: Tuesday, May 21, 2019 11:14 AM
> To: [email protected]; [email protected];
> [email protected]
> Cc: [email protected]; Andy Tang <[email protected]>; Yogesh
> Narayan Gaur <[email protected]>
> Subject: RE: [PATCH v4] clk: qoriq: add support for lx2160a
>
> Hello Stephen,
> I have incorporated review comments from
> https://patchwork.kernel.org/patch/10917171/
Hello Maintainers,
All the comments are addressed, Can you please take the patch?
Please see this is essential for new hardware support.

Regards,
Vabhav
>
> A gentle reminder to apply the patch
> https://patchwork.kernel.org/patch/10918407/.
>
> Regards,
> Vabhav
>
> > -----Original Message-----
> > From: Vabhav Sharma <[email protected]>
> > Sent: Friday, April 26, 2019 12:24 PM
> > To: [email protected]; [email protected]
> > Cc: [email protected]; [email protected]; Vabhav Sharma
> > <[email protected]>; Andy Tang <[email protected]>; Yogesh
> Narayan
> > Gaur <[email protected]>
> > Subject: [PATCH v4] clk: qoriq: add support for lx2160a
> >
> > Add clockgen support and configuration for NXP SoC lx2160a with
> > compatible property as "fsl,lx2160a-clockgen".
> >
> > Signed-off-by: Tang Yuantian <[email protected]>
> > Signed-off-by: Yogesh Gaur <[email protected]>
> > Signed-off-by: Vabhav Sharma <[email protected]>
> > Acked-by: Scott Wood <[email protected]>
> > Acked-by: Stephen Boyd <[email protected]>
> > Acked-by: Viresh Kumar <[email protected]>
> > ---
> > Changes for v4:
> > - Incorporated review comments from Stephen Boyd
> >
> > Changes for v3:
> > - Incorporated review comments of Rafael J. Wysocki
> > - Updated commit message
> >
> > Changes for v2:
> > - Subject line updated
> >
> > drivers/clk/clk-qoriq.c | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c index
> > 3d51d7c..1a15201 100644
> > --- a/drivers/clk/clk-qoriq.c
> > +++ b/drivers/clk/clk-qoriq.c
> > @@ -570,6 +570,17 @@ static const struct clockgen_chipinfo chipinfo[] = {
> > .flags = CG_VER3 | CG_LITTLE_ENDIAN,
> > },
> > {
> > + .compat = "fsl,lx2160a-clockgen",
> > + .cmux_groups = {
> > + &clockgen2_cmux_cga12, &clockgen2_cmux_cgb
> > + },
> > + .cmux_to_group = {
> > + 0, 0, 0, 0, 1, 1, 1, 1, -1
> > + },
> > + .pll_mask = 0x37,
> > + .flags = CG_VER3 | CG_LITTLE_ENDIAN,
> > + },
> > + {
> > .compat = "fsl,p2041-clockgen",
> > .guts_compat = "fsl,qoriq-device-config-1.0",
> > .init_periph = p2041_init_periph,
> > @@ -1427,6 +1438,7 @@ CLK_OF_DECLARE(qoriq_clockgen_ls1043a,
> > "fsl,ls1043a-clockgen", clockgen_init);
> > CLK_OF_DECLARE(qoriq_clockgen_ls1046a, "fsl,ls1046a-clockgen",
> > clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_ls1088a, "fsl,ls1088a-
> > clockgen", clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_ls2080a,
> > "fsl,ls2080a-clockgen", clockgen_init);
> > +CLK_OF_DECLARE(qoriq_clockgen_lx2160a, "fsl,lx2160a-clockgen",
> > +clockgen_init);
> > CLK_OF_DECLARE(qoriq_clockgen_p2041, "fsl,p2041-clockgen",
> > clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_p3041,
> > "fsl,p3041-clockgen", clockgen_init);
> > CLK_OF_DECLARE(qoriq_clockgen_p4080, "fsl,p4080-clockgen",
> > clockgen_init);
> > --
> > 2.7.4

2019-06-13 16:44:03

by Andy Tang

[permalink] [raw]
Subject: RE: [PATCH v4] clk: qoriq: add support for lx2160a

Hi Stephen, Mturquette,

Who will apply this patch? https://patchwork.kernel.org/patch/10918407/
All the comments are addressed and got acked by:
Acked-by: Scott Wood <[email protected]>
Acked-by: Stephen Boyd <[email protected]>
Acked-by: Viresh Kumar <[email protected]>

Could you please apply it?

BR,
Andy


> -----Original Message-----
> From: Vabhav Sharma
> Sent: 2019年5月23日 22:05
> To: [email protected]; [email protected];
> [email protected]; [email protected]
> Cc: [email protected]; [email protected]; Andy Tang
> <[email protected]>; Yogesh Narayan Gaur
> <[email protected]>
> Subject: RE: [PATCH v4] clk: qoriq: add support for lx2160a
>
> > -----Original Message-----
> > From: Vabhav Sharma
> > Sent: Tuesday, May 21, 2019 11:14 AM
> > To: [email protected]; [email protected];
> > [email protected]
> > Cc: [email protected]; Andy Tang <[email protected]>; Yogesh
> > Narayan Gaur <[email protected]>
> > Subject: RE: [PATCH v4] clk: qoriq: add support for lx2160a
> >
> > Hello Stephen,
> > I have incorporated review comments from
> > https://patchwork.kernel.org/patch/10917171/
> Hello Maintainers,
> All the comments are addressed, Can you please take the patch?
> Please see this is essential for new hardware support.
>
> Regards,
> Vabhav
> >
> > A gentle reminder to apply the patch
> > https://patchwork.kernel.org/patch/10918407/.
> >
> > Regards,
> > Vabhav
> >
> > > -----Original Message-----
> > > From: Vabhav Sharma <[email protected]>
> > > Sent: Friday, April 26, 2019 12:24 PM
> > > To: [email protected]; [email protected]
> > > Cc: [email protected]; [email protected]; Vabhav Sharma
> > > <[email protected]>; Andy Tang <[email protected]>; Yogesh
> > Narayan
> > > Gaur <[email protected]>
> > > Subject: [PATCH v4] clk: qoriq: add support for lx2160a
> > >
> > > Add clockgen support and configuration for NXP SoC lx2160a with
> > > compatible property as "fsl,lx2160a-clockgen".
> > >
> > > Signed-off-by: Tang Yuantian <[email protected]>
> > > Signed-off-by: Yogesh Gaur <[email protected]>
> > > Signed-off-by: Vabhav Sharma <[email protected]>
> > > Acked-by: Scott Wood <[email protected]>
> > > Acked-by: Stephen Boyd <[email protected]>
> > > Acked-by: Viresh Kumar <[email protected]>
> > > ---
> > > Changes for v4:
> > > - Incorporated review comments from Stephen Boyd
> > >
> > > Changes for v3:
> > > - Incorporated review comments of Rafael J. Wysocki
> > > - Updated commit message
> > >
> > > Changes for v2:
> > > - Subject line updated
> > >
> > > drivers/clk/clk-qoriq.c | 12 ++++++++++++
> > > 1 file changed, 12 insertions(+)
> > >
> > > diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c index
> > > 3d51d7c..1a15201 100644
> > > --- a/drivers/clk/clk-qoriq.c
> > > +++ b/drivers/clk/clk-qoriq.c
> > > @@ -570,6 +570,17 @@ static const struct clockgen_chipinfo chipinfo[] =
> {
> > > .flags = CG_VER3 | CG_LITTLE_ENDIAN,
> > > },
> > > {
> > > + .compat = "fsl,lx2160a-clockgen",
> > > + .cmux_groups = {
> > > + &clockgen2_cmux_cga12, &clockgen2_cmux_cgb
> > > + },
> > > + .cmux_to_group = {
> > > + 0, 0, 0, 0, 1, 1, 1, 1, -1
> > > + },
> > > + .pll_mask = 0x37,
> > > + .flags = CG_VER3 | CG_LITTLE_ENDIAN,
> > > + },
> > > + {
> > > .compat = "fsl,p2041-clockgen",
> > > .guts_compat = "fsl,qoriq-device-config-1.0",
> > > .init_periph = p2041_init_periph, @@ -1427,6 +1438,7 @@
> > > CLK_OF_DECLARE(qoriq_clockgen_ls1043a,
> > > "fsl,ls1043a-clockgen", clockgen_init);
> > > CLK_OF_DECLARE(qoriq_clockgen_ls1046a, "fsl,ls1046a-clockgen",
> > > clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_ls1088a,
> > > "fsl,ls1088a- clockgen", clockgen_init);
> > > CLK_OF_DECLARE(qoriq_clockgen_ls2080a,
> > > "fsl,ls2080a-clockgen", clockgen_init);
> > > +CLK_OF_DECLARE(qoriq_clockgen_lx2160a, "fsl,lx2160a-clockgen",
> > > +clockgen_init);
> > > CLK_OF_DECLARE(qoriq_clockgen_p2041, "fsl,p2041-clockgen",
> > > clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_p3041,
> > > "fsl,p3041-clockgen", clockgen_init);
> > > CLK_OF_DECLARE(qoriq_clockgen_p4080, "fsl,p4080-clockgen",
> > > clockgen_init);
> > > --
> > > 2.7.4

2019-06-25 22:59:02

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH v4] clk: qoriq: add support for lx2160a

Quoting Vabhav Sharma (2019-04-25 23:53:38)
> Add clockgen support and configuration for NXP SoC lx2160a
> with compatible property as "fsl,lx2160a-clockgen".
>
> Signed-off-by: Tang Yuantian <[email protected]>
> Signed-off-by: Yogesh Gaur <[email protected]>
> Signed-off-by: Vabhav Sharma <[email protected]>
> Acked-by: Scott Wood <[email protected]>
> Acked-by: Stephen Boyd <[email protected]>
> Acked-by: Viresh Kumar <[email protected]>
> ---

Applied to clk-next