2019-04-30 13:44:31

by Guido Günther

Subject: [PATCH] arm64: dts: imx8mq: Add a node for irqsteer

Add a node for the irqsteer interrupt controller found on the iMX8MQ
SoC.

Signed-off-by: Guido Günther <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 2cc939cfbd75..ce0e137ec8ee 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -798,6 +798,27 @@
};
};

+ bus@32c00000 { /* AIPS4 */
+ compatible = "fsl,imx8mq-aips-bus", "simple-bus";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x32c00000 0x32c00000 0x400000>;
+
+ irqsteer: interrupt-controller@32e2d000 {
+ compatible = "fsl,imx8m-irqsteer",
+ "fsl,imx-irqsteer";
+ reg = <0x32e2d000 0x1000>;
+ interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX8MQ_CLK_DISP_APB_ROOT>;
+ clock-names = "ipg";
+ fsl,channel = <0>;
+ fsl,num-irqs = <64>;
+ interrupt-controller;
+ interrupt-parent = <&gic>;
+ #interrupt-cells = <1>;
+ };
+ };
+
gpu: gpu@38000000 {
compatible = "vivante,gc";
reg = <0x38000000 0x40000>;
--
2.20.1

2019-04-30 13:52:37

by Lucas Stach

Subject: Re: [PATCH] arm64: dts: imx8mq: Add a node for irqsteer

Am Dienstag, den 30.04.2019, 15:41 +0200 schrieb Guido Günther:
> Add a node for the irqsteer interrupt controller found on the iMX8MQ
> SoC.
>
> Signed-off-by: Guido Günther <[email protected]>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 2cc939cfbd75..ce0e137ec8ee 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -798,6 +798,27 @@
>   };
>   };
>  
> + bus@32c00000 { /* AIPS4 */
> + compatible = "fsl,imx8mq-aips-bus", "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x32c00000 0x32c00000 0x400000>;
> +
> + irqsteer: interrupt-controller@32e2d000 {
> + compatible = "fsl,imx8m-irqsteer",
> +      "fsl,imx-irqsteer";

This fits on a single line, right?

> + reg = <0x32e2d000 0x1000>;
> + interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clk IMX8MQ_CLK_DISP_APB_ROOT>;
> + clock-names = "ipg";
> + fsl,channel = <0>;
> + fsl,num-irqs = <64>;
> + interrupt-controller;
> + interrupt-parent = <&gic>;

This is wrong, the irqsteer upstream IRQ is routed through the GPC like
all the other peripheral interrupts. You can just drop this property.

With this fixed:
Reviewed-by: Lucas Stach <[email protected]>

Regards,
Lucas

> + #interrupt-cells = <1>;
> + };
> + };
> +
>   gpu: gpu@38000000 {
>   compatible = "vivante,gc";
>   reg = <0x38000000 0x40000>;

2019-04-30 17:18:27

by Guido Günther

Subject: Re: [PATCH] arm64: dts: imx8mq: Add a node for irqsteer

Hi Lucas,
On Tue, Apr 30, 2019 at 03:50:04PM +0200, Lucas Stach wrote:
> Am Dienstag, den 30.04.2019, 15:41 +0200 schrieb Guido G?nther:
> > Add a node for the irqsteer interrupt controller found on the iMX8MQ
> > SoC.
> >
> > Signed-off-by: Guido G?nther <[email protected]>
> > ---
> > ?arch/arm64/boot/dts/freescale/imx8mq.dtsi | 21 +++++++++++++++++++++
> > ?1 file changed, 21 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > index 2cc939cfbd75..ce0e137ec8ee 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > @@ -798,6 +798,27 @@
> > ? };
> > ? };
> > ?
> > + bus@32c00000 { /* AIPS4 */
> > + compatible = "fsl,imx8mq-aips-bus", "simple-bus";
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + ranges = <0x32c00000 0x32c00000 0x400000>;
> > +
> > + irqsteer: interrupt-controller@32e2d000 {
> > + compatible = "fsl,imx8m-irqsteer",
> > + ?????"fsl,imx-irqsteer";
>
> This fits on a single line, right?

It went past the 80 char limit but it seems the dts is not super picky
about that so I changed that in v2.

>
> > + reg = <0x32e2d000 0x1000>;
> > + interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&clk IMX8MQ_CLK_DISP_APB_ROOT>;
> > + clock-names = "ipg";
> > + fsl,channel = <0>;
> > + fsl,num-irqs = <64>;
> > + interrupt-controller;
> > + interrupt-parent = <&gic>;
>
> This is wrong, the irqsteer upstream IRQ is routed through the GPC like
> all the other peripheral interrupts. You can just drop this property.

Fixed in v2. Thanks,
-- Guido

>
> With this fixed:
> Reviewed-by: Lucas Stach <[email protected]>
>
> Regards,
> Lucas
>
> > + #interrupt-cells = <1>;
> > + };
> > + };
> > +
> > ? gpu: gpu@38000000 {
> > ? compatible = "vivante,gc";
> > ? reg = <0x38000000 0x40000>;
>