From: Suresh Udipi <[email protected]>
It looks like v4.18-rc1 commit [0] which upstreams mld-1.8.0
commit [1] missed to fix the memory leak in mod_exit function.
Do it now.
[0] aba258b7310167 ("staging: most: cdev: fix chrdev_region leak")
[1] https://github.com/microchip-ais/linux/commit/a2d8f7ae7ea381
("staging: most: cdev: fix leak for chrdev_region")
Signed-off-by: Suresh Udipi <[email protected]>
Signed-off-by: Eugeniu Rosca <[email protected]>
---
drivers/staging/most/cdev/cdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/cdev/cdev.c b/drivers/staging/most/cdev/cdev.c
index f2b347cda8b7..d5f236889021 100644
--- a/drivers/staging/most/cdev/cdev.c
+++ b/drivers/staging/most/cdev/cdev.c
@@ -549,7 +549,7 @@ static void __exit mod_exit(void)
destroy_cdev(c);
destroy_channel(c);
}
- unregister_chrdev_region(comp.devno, 1);
+ unregister_chrdev_region(comp.devno, CHRDEV_REGION_SIZE);
ida_destroy(&comp.minor_id);
class_destroy(comp.class);
}
--
2.21.0
On Wed, Apr 24, 2019 at 09:23:43PM +0200, Eugeniu Rosca wrote:
> From: Suresh Udipi <[email protected]>
>
> It looks like v4.18-rc1 commit [0] which upstreams mld-1.8.0
> commit [1] missed to fix the memory leak in mod_exit function.
>
> Do it now.
>
> [0] aba258b7310167 ("staging: most: cdev: fix chrdev_region leak")
> [1] https://github.com/microchip-ais/linux/commit/a2d8f7ae7ea381
> ("staging: most: cdev: fix leak for chrdev_region")
>
> Signed-off-by: Suresh Udipi <[email protected]>
> Signed-off-by: Eugeniu Rosca <[email protected]>
> ---
> drivers/staging/most/cdev/cdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Christian, I'd like your ack/review on this before applying it.
thanks,
greg k-h
On Mi, 2019-04-24 at 21:23 +0200, Eugeniu Rosca wrote:
> External E-Mail
>
>
> From: Suresh Udipi <[email protected]>
>
> It looks like v4.18-rc1 commit [0] which upstreams mld-1.8.0
> commit [1] missed to fix the memory leak in mod_exit function.
>
> Do it now.
>
> [0] aba258b7310167 ("staging: most: cdev: fix chrdev_region leak")
> [1] https://github.com/microchip-ais/linux/commit/a2d8f7ae7ea381
> ("staging: most: cdev: fix leak for chrdev_region")
>
> Signed-off-by: Suresh Udipi <[email protected]>
> Signed-off-by: Eugeniu Rosca <[email protected]>
Acked-by: Christian Gromm <[email protected]>
> ---
> drivers/staging/most/cdev/cdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/most/cdev/cdev.c
> b/drivers/staging/most/cdev/cdev.c
> index f2b347cda8b7..d5f236889021 100644
> --- a/drivers/staging/most/cdev/cdev.c
> +++ b/drivers/staging/most/cdev/cdev.c
> @@ -549,7 +549,7 @@ static void __exit mod_exit(void)
> destroy_cdev(c);
> destroy_channel(c);
> }
> - unregister_chrdev_region(comp.devno, 1);
> + unregister_chrdev_region(comp.devno, CHRDEV_REGION_SIZE);
> ida_destroy(&comp.minor_id);
> class_destroy(comp.class);
> }
On Wed, Apr 24, 2019 at 09:23:43PM +0200, Eugeniu Rosca wrote:
> From: Suresh Udipi <[email protected]>
>
> It looks like v4.18-rc1 commit [0] which upstreams mld-1.8.0
> commit [1] missed to fix the memory leak in mod_exit function.
>
> Do it now.
>
> [0] aba258b7310167 ("staging: most: cdev: fix chrdev_region leak")
> [1] https://github.com/microchip-ais/linux/commit/a2d8f7ae7ea381
> ("staging: most: cdev: fix leak for chrdev_region")
>
> Signed-off-by: Suresh Udipi <[email protected]>
> Signed-off-by: Eugeniu Rosca <[email protected]>
> Acked-by: Christian Gromm <[email protected]>
In the future, please use the "correct" way to mark a fixup patch. For
this, it would be:
Fixes: aba258b73101 ("staging: most: cdev: fix chrdev_region leak")
I'll go add it, and the needed stable tag to the patch when applying it.
thanks,
greg k-h
On Thu, May 02, 2019 at 07:39:20PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Apr 24, 2019 at 09:23:43PM +0200, Eugeniu Rosca wrote:
> > From: Suresh Udipi <[email protected]>
> >
> > It looks like v4.18-rc1 commit [0] which upstreams mld-1.8.0
> > commit [1] missed to fix the memory leak in mod_exit function.
> >
> > Do it now.
> >
> > [0] aba258b7310167 ("staging: most: cdev: fix chrdev_region leak")
> > [1] https://github.com/microchip-ais/linux/commit/a2d8f7ae7ea381
> > ("staging: most: cdev: fix leak for chrdev_region")
> >
> > Signed-off-by: Suresh Udipi <[email protected]>
> > Signed-off-by: Eugeniu Rosca <[email protected]>
> > Acked-by: Christian Gromm <[email protected]>
>
> In the future, please use the "correct" way to mark a fixup patch. For
> this, it would be:
> Fixes: aba258b73101 ("staging: most: cdev: fix chrdev_region leak")
>
> I'll go add it, and the needed stable tag to the patch when applying it.
Thank you for the suggestion. I'll follow it next time.
>
> thanks,
>
> greg k-h
--
Best Regards,
Eugeniu.